Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WaitForSnapshotStepTests#testHashcodeAndEquals fails #51377

Closed
dnhatn opened this issue Jan 23, 2020 · 1 comment · Fixed by #51379
Closed

WaitForSnapshotStepTests#testHashcodeAndEquals fails #51377

dnhatn opened this issue Jan 23, 2020 · 1 comment · Fixed by #51379
Labels
:Data Management/ILM+SLM Index and Snapshot lifecycle management >test-failure Triaged test failures from CI

Comments

@dnhatn
Copy link
Member

dnhatn commented Jan 23, 2020

Failed on my backport PR: https://gradle-enterprise.elastic.co/s/w35l6ouk6uzsw and reproducible on 7.x.

./gradlew ':x-pack:plugin:core:test' --tests "org.elasticsearch.xpack.core.ilm.WaitForSnapshotStepTests.testHashcodeAndEquals" -Dtests.seed=F61F844292A93219 -Dtests.security.manager=true -Dtests.locale=fr-BE -Dtests.timezone=Australia/South -Dcompiler.java=13 -Druntime.java=8

org.elasticsearch.xpack.core.ilm.WaitForSnapshotStepTests > testHashcodeAndEquals FAILED
    java.lang.AssertionError: WaitForSnapshotStep mutation should not be equal to original
    Expected: not <{"phase":"SmZLaEYALs","action":"rvBecejUXU","name":"JvfEvWSTLz"} => {"phase":"OvCHIYVrPd","action":"uWOZHJNBGg","name":"EUaKQDgdvB"}>
         but: was <{"phase":"SmZLaEYALs","action":"rvBecejUXU","name":"JvfEvWSTLz"} => {"phase":"OvCHIYVrPd","action":"uWOZHJNBGg","name":"EUaKQDgdvB"}>
@dnhatn dnhatn added >test-failure Triaged test failures from CI :Data Management/ILM+SLM Index and Snapshot lifecycle management labels Jan 23, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-features (:Core/Features/ILM+SLM)

@dnhatn dnhatn mentioned this issue Jan 23, 2020
Merged
dakrone added a commit to dakrone/elasticsearch that referenced this issue Jan 23, 2020
@dakrone
Fix testHashcodeAndEquals mutation for WaitForSnapshotStep
fd8a0db 
This fixes the test failure, it was randomness returning the same policy
rather than a new one. Switched to use `randomValueOtherThan`.

Resolves elastic#51377
@dakrone dakrone mentioned this issue Jan 23, 2020
Merged
dakrone added a commit that referenced this issue Jan 23, 2020
@dakrone
Fix testHashcodeAndEquals mutation for WaitForSnapshotStep (#51379)
ac2e7c1 
This fixes the test failure, it was randomness returning the same policy
rather than a new one. Switched to use `randomValueOtherThan`.

Resolves #51377
dakrone added a commit that referenced this issue Jan 23, 2020
@dakrone
Fix testHashcodeAndEquals mutation for WaitForSnapshotStep (#51379)
31747de 
This fixes the test failure, it was randomness returning the same policy
rather than a new one. Switched to use `randomValueOtherThan`.

Resolves #51377
dakrone added a commit that referenced this issue Jan 23, 2020
@dakrone
Fix testHashcodeAndEquals mutation for WaitForSnapshotStep (#51379)
095438c 
This fixes the test failure, it was randomness returning the same policy
rather than a new one. Switched to use `randomValueOtherThan`.

Resolves #51377
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
:Data Management/ILM+SLM Index and Snapshot lifecycle management >test-failure Triaged test failures from CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix testHashcodeAndEquals mutation for WaitForSnapshotStep dakrone/elasticsearch
2 participants
@dnhatn @elasticmachine