-
Notifications
You must be signed in to change notification settings - Fork 24.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add metadata to exception when ApiKey/Token services are not enabled #52311
Labels
:Security/Authentication
Logging in, Usernames/passwords, Realms (Native/LDAP/AD/SAML/PKI/etc)
Comments
Pinging @elastic/es-security (:Security/Authentication) |
This was referenced Feb 13, 2020
tvernum
added a commit
to tvernum/elasticsearch
that referenced
this issue
Feb 26, 2020
This change adds a new exception with consistent metadata for when security features are not enabled. This allows clients to be able to tell that an API failed due to a configuration option, and respond accordingly. Relates: kibana#55255 Resolves: elastic#52311
tvernum
added a commit
to tvernum/elasticsearch
that referenced
this issue
Mar 23, 2020
This change adds a new exception with consistent metadata for when security features are not enabled. This allows clients to be able to tell that an API failed due to a configuration option, and respond accordingly. Relates: kibana#55255 Resolves: elastic#52311, elastic#47759 Backport of: elastic#52811
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
:Security/Authentication
Logging in, Usernames/passwords, Realms (Native/LDAP/AD/SAML/PKI/etc)
Replaces: #51585
Relates: elastic/kibana#55255
There are cases where the ApiKeyService and TokenService throw exceptions if they are disabled (e.g. you cannot list API Keys, or create an API Key if the service is disabled).
In these cases we should add a metadata field to the thrown exception (e.g.
"es.disabled.feature" : "API-Key-Service"
) so that consumers of the REST API can detect this root cause without needing to parse error messages.The text was updated successfully, but these errors were encountered: