Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated String concat in Painless #52601

Open
jdconrad opened this issue Feb 20, 2020 · 3 comments
Open

Remove deprecated String concat in Painless #52601

jdconrad opened this issue Feb 20, 2020 · 3 comments
Labels
:Core/Infra/Scripting Scripting abstractions, Painless, and Mustache >refactoring Team:Core/Infra Meta label for core/infra team

Comments

@jdconrad
Copy link
Contributor

Painless currently supports two versions of String concatenation using the + operator in Painless. In Java 8 and below, a traditional StringBuilder is used. In Java 9 and above a new technique is used involving invokedynamic instructions. We should remove the older version as we will no longer support Java 8 in our next major release.
@jdconrad jdconrad added :Core/Infra/Scripting Scripting abstractions, Painless, and Mustache >refactoring labels Feb 20, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (:Core/Infra/Scripting)

@rjernst rjernst added the Team:Core/Infra Meta label for core/infra team label May 4, 2020
@rjernst rjernst added the needs:triage Requires assignment of a team area label label Dec 3, 2020
@stu-elastic stu-elastic added v8.0.0 and removed needs:triage Requires assignment of a team area label labels Dec 9, 2020
@danielcr10
Copy link

Hi @jdconrad , I'm new to the project and would like to try to contribute. Can I try this?

@danielcr10 danielcr10 mentioned this issue Jun 16, 2021
Closed
@arteam arteam added v8.1.0 and removed v8.0.0 labels Jan 12, 2022
@mark-vieira mark-vieira added v8.2.0 and removed v8.1.0 labels Feb 2, 2022
@icemakegirl
Copy link

Is somebody working here?
I'd like undertain better

@pugnascotia pugnascotia removed the v8.4.0 label Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
:Core/Infra/Scripting Scripting abstractions, Painless, and Mustache >refactoring Team:Core/Infra Meta label for core/infra team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove deprecated string concat painless