Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] LocalIndicesCleanerTests.testHandlesWatcherHistory fails reproducibly #53025

Closed
mark-vieira opened this issue Mar 2, 2020 · 3 comments · Fixed by #53066
Closed

[CI] LocalIndicesCleanerTests.testHandlesWatcherHistory fails reproducibly #53025

mark-vieira opened this issue Mar 2, 2020 · 3 comments · Fixed by #53066
Assignees
@jaymode
Labels
:Data Management/Watcher >test-failure Triaged test failures from CI

Comments

@mark-vieira
Copy link
Contributor

mark-vieira commented Mar 2, 2020 •
edited
Loading

This test has failed a few times no on master:

org.elasticsearch.xpack.monitoring.cleaner.local.LocalIndicesCleanerTests > testHandlesWatcherHistory FAILED
    java.lang.AssertionError: 
    Expected: <7>
         but: was <6>
        at __randomizedtesting.SeedInfo.seed([4A140D21CCAC26DF:F8559B4CC0706069]:0)
        at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:18)
        at org.junit.Assert.assertThat(Assert.java:956)
        at org.junit.Assert.assertThat(Assert.java:923)
        at org.elasticsearch.xpack.monitoring.cleaner.local.LocalIndicesCleanerTests.lambda$assertIndicesCount$0(LocalIndicesCleanerTests.java:61)
        at org.elasticsearch.test.ESTestCase.assertBusy(ESTestCase.java:881)
        at org.elasticsearch.test.ESTestCase.assertBusy(ESTestCase.java:854)
        at org.elasticsearch.xpack.monitoring.cleaner.local.LocalIndicesCleanerTests.assertIndicesCount(LocalIndicesCleanerTests.java:54)
        at org.elasticsearch.xpack.monitoring.cleaner.local.LocalIndicesCleanerTests.testHandlesWatcherHistory(LocalIndicesCleanerTests.java:79)
REPRODUCE WITH: ./gradlew ':x-pack:plugin:monitoring:test' --tests "org.elasticsearch.xpack.monitoring.cleaner.local.LocalIndicesCleanerTests.testHandlesWatcherHistory" -Dtests.seed=4A140D21CCAC26DF -Dtests.security.manager=true -Dtests.locale=es-CL -Dtests.timezone=America/Caracas -Dcompiler.java=13

The example above reproduced for me locally.

https://gradle-enterprise.elastic.co/s/qevr265r5v2bo/tests/iu7lux6ygquas-ar7w2ggk5jvdw
@mark-vieira mark-vieira added >test-failure Triaged test failures from CI :Data Management/Watcher labels Mar 2, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-features (:Core/Features/Watcher)

@mark-vieira
Copy link
Contributor Author

Since this reproduces I've muted this in master with 645d0bb.

@jaymode jaymode self-assigned this Mar 3, 2020
@jaymode
Copy link
Member

jaymode commented Mar 3, 2020

This one is probably caused by changing this index to be hidden. I will look into it.

jaymode added a commit to jaymode/elasticsearch that referenced this issue Mar 3, 2020
@jaymode
Fix LocalIndicesCleanerTests with hidden index
ae2411f 
The LocalIndicesCleanerTests#testHandlesWatcherHistory creates random
watch history indices with a version of 1-20. When the version is 11,
this matches the existing watch history template that has the
index.hidden setting set to true and the check for indices in this test
did not include hidden indices. The change here updates the indices
options to include hidden indices.

Closes elastic#53025
@jaymode jaymode mentioned this issue Mar 3, 2020
Merged
jaymode added a commit to jaymode/elasticsearch that referenced this issue Mar 3, 2020
@jaymode
Fix LocalIndicesCleanerTests with hidden index
e86db7f 
The LocalIndicesCleanerTests#testHandlesWatcherHistory creates random
watch history indices with a version of 1-20. When the version is 11,
this matches the existing watch history template that has the
index.hidden setting set to true and the check for indices in this test
did not include hidden indices. The change here updates the indices
options to include hidden indices.

Closes elastic#53025
jaymode added a commit that referenced this issue Mar 4, 2020
@jaymode
Fix LocalIndicesCleanerTests with hidden index (#53066)
2930b32 
The LocalIndicesCleanerTests#testHandlesWatcherHistory creates random
watch history indices with a version of 1-20. When the version is 11,
this matches the existing watch history template that has the
index.hidden setting set to true and the check for indices in this test
did not include hidden indices. The change here updates the indices
options to include hidden indices.

Closes #53025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jaymode jaymode

Labels
:Data Management/Watcher >test-failure Triaged test failures from CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix LocalIndicesCleanerTests with hidden index jaymode/elasticsearch
3 participants
@mark-vieira @jaymode @elasticmachine