Highlight for Pinned Query not Working

[jesserobles]

Elasticsearch version (bin/elasticsearch --version): 7.4.2, 7.6.1

Plugins installed: repository-s3

JVM version (java -version):
openjdk 13.0.2 2020-01-14 OpenJDK Runtime Environment AdoptOpenJDK (build 13.0.2+8) OpenJDK 64-Bit Server VM AdoptOpenJDK (build 13.0.2+8, mixed mode, sharing)

OS version (uname -a if on a Unix-like system):
Docker (from docker.elastic.co): Linux ce1452e52a27 4.19.76-linuxkit #1 SMP Thu Oct 17 19:31:58 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Description of the problem including expected versus actual behavior:
Highlighting does not work when wrapping queries using the Pinned query, even though the issue at #44074 describes pinned results as being highlight-able. At the very least, the organic results should be highlighted.
Steps to reproduce:

Please include a minimal but complete recreation of the problem, including
(e.g.) index creation, mappings, settings, query etc. The easier you make for
us to reproduce it, the more likely that somebody will take the time to look at it.

POST _bulk
{ "index" : { "_index" : "test", "_id" : "1" } }
{ "title" : "elasticsearch is great" }
{ "index" : { "_index" : "test", "_id" : "2" } }
{ "title" : "kibana is pretty cool too" }
{ "index" : { "_index" : "test", "_id" : "3" } }
{ "title" : "another elasticsearch document" }

# Highlighting doesn't work with this:
GET test/_search
{
 "highlight": {
   "fields": {
     "title": {}
   }
 }, 
 "query": {
   "pinned": {
     "ids": ["3"],
     "organic": {
       "match": {
         "title": "elasticsearch"
       }
     }
   }
 }
}

# Highlighting works with the organic query:
GET test/_search
{
 "highlight": {
   "fields": {
     "title": {}
   }
 }, 
 "query": {
   "match": {
     "title": "elasticsearch"
   }
 }
}

[elasticmachine]

Pinging @elastic/es-search (:Search/Highlighting)

[markharwood]

I'll look into this. A workaround is to reiterate the organic part of the query in the highlight section like so:

GET test/_search
{
  "highlight": {
	"fields": {
	  "title": {}
	},
	"highlight_query": {
	  "match": {"title": "elasticsearch"}
	}
  },
  "query": {
	"pinned": {
	  "ids": [
		"3"
	  ],
	  "organic": {
		"match": {"title": "elasticsearch"}
	  }
	}
  }
}

[markharwood]

Will be fixed in 7.7 onwards. Thanks for reporting @jesserobles

[jesserobles]

Awesome! Thanks for the workaround, and for fixing it so quickly @markharwood .