ES RedHat/Centos Init script not exporting JAVA_HOME

[alex-leonhardt]

Hi,

export JAVA_HOME is missing from the init script in ES RPM 1.0.1-1 noarch.

when trying to make ES use a specific version of Java it fails until one "fixes" the init script to include :

[...]

[ -e /etc/sysconfig/$prog ] && . /etc/sysconfig/$prog

export ES_HEAP_SIZE
export ES_HEAP_NEWSIZE
export ES_DIRECT_SIZE
export ES_JAVA_OPTS
export JAVA_HOME

lockfile=/var/lock/subsys/$prog

[...]

Alex

[alappe]

This really would be an easy fix to get a working default setup on centos… 👍

[electrical]

For what specific use case would you need to export it?
If you would set JAVA_HOME in the /etc/sysconfig/$prog file it should be fine?
Or is it being used somewhere else as well?

[alappe]

Searching for a solution why my installation didn't work, I came across @alex-leonhardt fix – and it worked. After posting the comment, I came to realize I didn't really understand why this makes any difference, since the variable should already be exported… but nevertheless it works here.

Maybe @alex-leonhardt has more insight… if not, I'd need to build up a clean system to test with/without, which I cannot find the time this week…

[alex-leonhardt]

Wow, this is so long ago I can't remember exactly; there was a good reason for having to export it.

[clintongormley]

Could it be that, when the script drops privileges, that it also resets the environment?

[clintongormley]

Would making this change break anything? If not, I'd suggest we do it.

[electrical]

I don't expect it to break anything if we would export it.

[clintongormley]

@electrical OK thanks. Does that mean you're going to do it?