Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scripted metric should fail gracefully on unsupported return types #54665

Closed
not-napoleon opened this issue Apr 2, 2020 · 1 comment · Fixed by #54692
Closed

Scripted metric should fail gracefully on unsupported return types #54665

not-napoleon opened this issue Apr 2, 2020 · 1 comment · Fixed by #54692
Assignees
@imotov
Labels
:Analytics/Aggregations Aggregations >bug

Comments

@not-napoleon
Copy link
Member

not-napoleon commented Apr 2, 2020 •
edited by polyfractal
Loading

Scripted Metric aggregation running against an invalid return type can fail since it does not know how to serialize unknown types returned from scripts
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-analytics-geo (:Analytics/Aggregations)

@imotov imotov self-assigned this Apr 2, 2020
imotov added a commit to imotov/elasticsearch that referenced this issue Apr 2, 2020
@imotov
Improve robustness of Query Result serializations
e2ae755 
Makes query result serialization more robust by propagating possible
IOExceptions that can occur during shard level result serialization to the
caller instead of throwing AssertError that is not intercepted.

Fixes elastic#54665
@imotov imotov mentioned this issue Apr 2, 2020
Merged
imotov added a commit that referenced this issue Apr 9, 2020
@imotov
Improve robustness of Query Result serializations (#54692)
af7ea67 
Makes query result serialization more robust by propagating possible
IOExceptions that can occur during shard level result serialization to the
caller instead of throwing AssertionError that is not intercepted.

Fixes #54665
imotov added a commit to imotov/elasticsearch that referenced this issue Apr 9, 2020
@imotov
Improve robustness of Query Result serializations (elastic#54692)
8315562 
Makes query result serialization more robust by propagating possible
IOExceptions that can occur during shard level result serialization to the
caller instead of throwing AssertionError that is not intercepted.

Fixes elastic#54665
@imotov imotov mentioned this issue Apr 9, 2020
Merged
imotov added a commit to imotov/elasticsearch that referenced this issue Apr 9, 2020
@imotov
Improve robustness of Query Result serializations (elastic#54692)
23fae74 
Makes query result serialization more robust by propagating possible
IOExceptions that can occur during shard level result serialization to the
caller instead of throwing AssertionError that is not intercepted.

Fixes elastic#54665
@imotov imotov mentioned this issue Apr 9, 2020
Merged
imotov added a commit that referenced this issue Apr 10, 2020
@imotov
Improve robustness of Query Result serializations (#54692) (#55028)
da976d2 
Makes query result serialization more robust by propagating possible
IOExceptions that can occur during shard level result serialization to the
caller instead of throwing AssertionError that is not intercepted.

Fixes #54665
imotov added a commit that referenced this issue Apr 10, 2020
@imotov
Improve robustness of Query Result serializations (#54692) (#55029)
6135cec 
Makes query result serialization more robust by propagating possible
IOExceptions that can occur during shard level result serialization to the
caller instead of throwing AssertionError that is not intercepted.

Fixes #54665
@polyfractal polyfractal mentioned this issue Apr 13, 2020
Closed
yyff pushed a commit to yyff/elasticsearch that referenced this issue Apr 17, 2020
@imotov
Improve robustness of Query Result serializations (elastic#54692)
46d9ea2 
Makes query result serialization more robust by propagating possible
IOExceptions that can occur during shard level result serialization to the
caller instead of throwing AssertionError that is not intercepted.

Fixes elastic#54665
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@imotov imotov

Labels
:Analytics/Aggregations Aggregations >bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve robustness of Query Result serializations imotov/elasticsearch
3 participants
@imotov @not-napoleon @elasticmachine