Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Snapshot Delete Dry Run #56660

Open
original-brownbear opened this issue May 13, 2020 · 3 comments
Open

Implement Snapshot Delete Dry Run #56660

original-brownbear opened this issue May 13, 2020 · 3 comments
Labels
:Distributed/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs >enhancement Team:Distributed Meta label for distributed team

Comments

@original-brownbear
Copy link
Member

We've had various requests for a way of determining the storage savings that could be had from deleting a snapshot before deleting it. Also, we need a way to determine the size of a snapshot repository via an API call.

After discussing this during snapshot resiliency sync we decided that both things could be had by adding a dry-run API for snapshot deletes that returns the bytes that could be saved for a given delete request. This would allow getting the incremental size of a snapshot when dry-running single snapshot deletes as well as getting the size of the full repository by dry-running a delete for all snapshots via snapshot name *.
@original-brownbear original-brownbear added >enhancement :Distributed/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs labels May 13, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (:Distributed/Snapshot/Restore)

@elasticmachine elasticmachine added the Team:Distributed Meta label for distributed team label May 13, 2020
@original-brownbear
Copy link
Member Author

cc @paulcoghlan @suyograo

@DaveCTurner
Copy link
Contributor

Linking https://discuss.elastic.co/t/s3-bucket-size-holding-the-snapshots-is-2-2-5x-of-the-total-disk-used-of-the-cluster/278944 as another case where this would be useful.

@Leaf-Lin Leaf-Lin mentioned this issue Sep 16, 2021
Closed
@Leaf-Lin Leaf-Lin mentioned this issue Oct 29, 2021
Open
@arteam arteam self-assigned this Nov 10, 2021
@Leaf-Lin Leaf-Lin added the good first issue low hanging fruit label Jun 2, 2022
@Leaf-Lin Leaf-Lin removed the good first issue low hanging fruit label Jun 15, 2022
DaveCTurner added a commit to DaveCTurner/elasticsearch that referenced this issue Oct 13, 2023
@DaveCTurner
Broader snapshot delete size tracking
c377928 
This commit moves the tracking of the number & size of deleted blobs
during cleanup to the top level so that in future they might track the
shard-level deletions too.

Relates elastic#56660
@DaveCTurner DaveCTurner mentioned this issue Oct 13, 2023
Merged
DaveCTurner added a commit that referenced this issue Oct 13, 2023
@DaveCTurner
Broader snapshot delete size tracking (#100791)
e9171fc 
This commit moves the tracking of the number & size of deleted blobs
during cleanup to the top level so that in future they might track the
shard-level deletions too.

Relates #56660
@arteam arteam removed their assignment Feb 20, 2024
@elastic elastic deleted a comment from elasticsearchmachine Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
:Distributed/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs >enhancement Team:Distributed Meta label for distributed team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@arteam @DaveCTurner @original-brownbear @elasticmachine @Leaf-Lin