Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mustache dependency not shaded #6192

Closed
plaflamme opened this issue May 15, 2014 · 1 comment · Fixed by #6193
Closed

Mustache dependency not shaded #6192

plaflamme opened this issue May 15, 2014 · 1 comment · Fixed by #6193
Assignees
@s1monw
Labels
>bug v1.1.2 v1.2.0 v2.0.0-beta1

Comments

@plaflamme
Copy link

The com.github.spullara.mustache.java:compiler dependency is not being shaded in the Elasticsearch fat jar:

$ curl -s http://repo1.maven.org/maven2/org/elasticsearch/elasticsearch/1.1.1/elasticsearch-1.1.1.jar | jar tv | grep -i mustache
     0 Wed Apr 16 14:28:38 EDT 2014 org/elasticsearch/script/mustache/
  5705 Wed Apr 16 14:28:38 EDT 2014 org/elasticsearch/script/mustache/MustacheScriptEngineService.class
  1598 Wed Apr 16 14:28:38 EDT 2014 org/elasticsearch/script/mustache/JsonEscapingMustacheFactory.class
  3246 Wed Apr 16 14:28:38 EDT 2014 org/elasticsearch/script/mustache/MustacheScriptEngineService$MustacheExecutableScript.class
     0 Wed Apr 16 14:28:42 EDT 2014 com/github/mustachejava/
   175 Wed Apr 16 14:28:42 EDT 2014 com/github/mustachejava/Binding.class
   639 Wed Apr 16 14:28:42 EDT 2014 com/github/mustachejava/Code.class
     0 Wed Apr 16 14:28:42 EDT 2014 com/github/mustachejava/codes/
  6514 Wed Apr 16 14:28:42 EDT 2014 com/github/mustachejava/codes/DefaultCode.class
  1951 Wed Apr 16 14:28:42 EDT 2014 com/github/mustachejava/codes/DefaultMustache.class
   758 Wed Apr 16 14:28:42 EDT 2014 com/github/mustachejava/codes/DepthLimitedWriter.class
  4121 Wed Apr 16 14:28:42 EDT 2014 com/github/mustachejava/codes/ExtendCode.class
  1025 Wed Apr 16 14:28:42 EDT 2014 com/github/mustachejava/codes/ExtendNameCode.class
  1737 Wed Apr 16 14:28:42 EDT 2014 com/github/mustachejava/codes/IterableCode$1.class
  5438 Wed Apr 16 14:28:42 EDT 2014 com/github/mustachejava/codes/IterableCode.class
  2183 Wed Apr 16 14:28:42 EDT 2014 com/github/mustachejava/codes/NotIterableCode.class
  3939 Wed Apr 16 14:28:42 EDT 2014 com/github/mustachejava/codes/PartialCode.class
  1772 Wed Apr 16 14:28:42 EDT 2014 com/github/mustachejava/codes/ValueCode$1.class
  5351 Wed Apr 16 14:28:42 EDT 2014 com/github/mustachejava/codes/ValueCode.class
[...]

Strange since it is being included in the list of shaded dependencies: https://github.com/elasticsearch/elasticsearch/blob/master/pom.xml#L585

Maybe it's because it is declared as an optional dependency? https://github.com/elasticsearch/elasticsearch/blob/master/pom.xml#L176
@s1monw s1monw added bug and removed v1.0.4 labels May 15, 2014
@s1monw s1monw self-assigned this May 15, 2014
@s1monw
Copy link
Contributor

s1monw commented May 15, 2014

good catch I will provide a PR in a bit...

@s1monw s1monw mentioned this issue May 15, 2014
Merged
s1monw added a commit to s1monw/elasticsearch that referenced this issue May 15, 2014
@s1monw
Shade mustache into org.elasticsearch.common package
13f37b3 
Previously we shared the jar but never rewrote the packages such
that the shading had no effect.

Closes elastic#6192
s1monw added a commit that referenced this issue May 15, 2014
@s1monw
Shade mustache into org.elasticsearch.common package
7dcb9d4 
Previously we shared the jar but never rewrote the packages such
that the shading had no effect.

Closes #6192
s1monw added a commit that referenced this issue May 15, 2014
@s1monw
Shade mustache into org.elasticsearch.common package
45314bc 
Previously we shared the jar but never rewrote the packages such
that the shading had no effect.

Closes #6192
mute pushed a commit to mute/elasticsearch that referenced this issue Jul 29, 2015
@s1monw
Shade mustache into org.elasticsearch.common package
1aea0ff 
Previously we shared the jar but never rewrote the packages such
that the shading had no effect.

Closes elastic#6192
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@s1monw s1monw

Labels
>bug v1.1.2 v1.2.0 v2.0.0-beta1
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Shade mustache into org.elasticsearch.common package s1monw/elasticsearch
2 participants
@plaflamme @s1monw