Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] UpdateThreadPoolSettingsTests testFixedExecutorType failure #63131

Closed
astefan opened this issue Oct 1, 2020 · 3 comments · Fixed by #63700
Closed

[CI] UpdateThreadPoolSettingsTests testFixedExecutorType failure #63131

astefan opened this issue Oct 1, 2020 · 3 comments · Fixed by #63700
Assignees
@jaymode
Labels
:Core/Infra/Settings Settings infrastructure and APIs Team:Core/Infra Meta label for core/infra team >test-failure Triaged test failures from CI

Comments

@astefan
Copy link
Contributor

astefan commented Oct 1, 2020

Build scan: https://gradle-enterprise.elastic.co/s/safmn5nukss7y

Repro line: ./gradlew ':server:test' --tests "org.elasticsearch.threadpool.UpdateThreadPoolSettingsTests.testFixedExecutorType" -Dtests.seed=314CD7EE34B70039 -Dtests.security.manager=true -Dtests.locale=sq -Dtests.timezone=Australia/Sydney -Druntime.java=8

Reproduces locally?: No

Applicable branches: 7.x

Failure history: failed 5 times in the last 30 days. First failure on Sept 23rd.

Failure excerpt:

org.elasticsearch.threadpool.UpdateThreadPoolSettingsTests > testFixedExecutorType FAILED
    java.lang.IllegalArgumentException: Failed to parse value [15] for setting [thread_pool.system_write.size] must be <= 13
        at __randomizedtesting.SeedInfo.seed([314CD7EE34B70039:18FECDC3778D68C]:0)
        at org.elasticsearch.common.settings.Setting.parseInt(Setting.java:1260)
        at org.elasticsearch.common.settings.Setting.parseInt(Setting.java:1249)
        at org.elasticsearch.threadpool.FixedExecutorBuilder.lambda$new$1(FixedExecutorBuilder.java:117)
        at org.elasticsearch.common.settings.Setting.get(Setting.java:441)
        at org.elasticsearch.common.settings.Setting.get(Setting.java:435)
        at org.elasticsearch.threadpool.FixedExecutorBuilder.getSettings(FixedExecutorBuilder.java:131)
        at org.elasticsearch.threadpool.FixedExecutorBuilder.getSettings(FixedExecutorBuilder.java:38)
        at org.elasticsearch.threadpool.ThreadPool.<init>(ThreadPool.java:214)
        at org.elasticsearch.threadpool.UpdateThreadPoolSettingsTests.testFixedExecutorType(UpdateThreadPoolSettingsTests.java:107)
@astefan astefan added :Core/Infra/Settings Settings infrastructure and APIs >test-failure Triaged test failures from CI labels Oct 1, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (:Core/Infra/Settings)

@elasticmachine elasticmachine added the Team:Core/Infra Meta label for core/infra team label Oct 1, 2020
@rjernst
Copy link
Member

rjernst commented Oct 6, 2020

It looks like this started failing right after #61655 was merged. @jaymode Can you take a look? My hunch is this randomly fails when the new SYSTEM_WRITE thread pool gets randomly selected in this test.

@cbuescher
Copy link
Member

Another one today on 7.10: https://gradle-enterprise.elastic.co/s/xklyf67werd5c

jaymode added a commit to jaymode/elasticsearch that referenced this issue Oct 14, 2020
@jaymode
Fix threadpool setting test for system_write
3f2411e 
This commit fixes the UpdateThreadPoolSettingsTests to be aware of the
hard limit on the maximum size of the system_write executor. This
executor has a hard limit that matches the write executor, which is
the number of allocated processors.

Closes elastic#63131
@jaymode jaymode mentioned this issue Oct 14, 2020
Merged
jaymode added a commit that referenced this issue Oct 14, 2020
@jaymode
Fix threadpool setting test for system_write (#63700)
b33cfa5 
This commit fixes the UpdateThreadPoolSettingsTests to be aware of the
hard limit on the maximum size of the system_write executor. This
executor has a hard limit that matches the write executor, which is
the number of allocated processors.

Closes #63131
jaymode added a commit to jaymode/elasticsearch that referenced this issue Oct 14, 2020
@jaymode
Fix threadpool setting test for system_write
1a74bc7 
This commit fixes the UpdateThreadPoolSettingsTests to be aware of the
hard limit on the maximum size of the system_write executor. This
executor has a hard limit that matches the write executor, which is
the number of allocated processors.

Closes elastic#63131
Backport elastic#63700
This was referenced Oct 14, 2020
Merged
Merged
jaymode added a commit that referenced this issue Oct 14, 2020
@jaymode
Fix threadpool setting test for system_write (#63706)
822fea9 
This commit fixes the UpdateThreadPoolSettingsTests to be aware of the
hard limit on the maximum size of the system_write executor. This
executor has a hard limit that matches the write executor, which is
the number of allocated processors.

Closes #63131
Backport #63700
jaymode added a commit that referenced this issue Oct 14, 2020
@jaymode
Fix threadpool setting test for system_write (#63705)
ab56f10 
This commit fixes the UpdateThreadPoolSettingsTests to be aware of the
hard limit on the maximum size of the system_write executor. This
executor has a hard limit that matches the write executor, which is
the number of allocated processors.

Closes #63131
Backport #63700
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jaymode jaymode

Labels
:Core/Infra/Settings Settings infrastructure and APIs Team:Core/Infra Meta label for core/infra team >test-failure Triaged test failures from CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix threadpool setting test for system_write jaymode/elasticsearch
5 participants
@rjernst @astefan @jaymode @cbuescher @elasticmachine