New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow keyword_marker filter to be updateable #65355
Comments
Pinging @elastic/es-search (Team:Search) |
I can see the benefit of being able to update the |
Currently we don't allow `keyword_marker` filter file resources to be reloaded via the `_reload_search_analyzers` API. It would make sense to allow reloading this when the file content has changed to allow e.g. for updating stemmer exeption rules at search time without having to close and re-open the index in question. This change adds the updateable flag to this token filter in the same way it is used for synonym filters. Analyzers containing updateable keyword_marker filters would not be allowed to be used at index time but at search time only, similar to what we allow for synonym filters. Closes #65355
Currently we don't allow `keyword_marker` filter file resources to be reloaded via the `_reload_search_analyzers` API. It would make sense to allow reloading this when the file content has changed to allow e.g. for updating stemmer exeption rules at search time without having to close and re-open the index in question. This change adds the updateable flag to this token filter in the same way it is used for synonym filters. Analyzers containing updateable keyword_marker filters would not be allowed to be used at index time but at search time only, similar to what we allow for synonym filters. Closes #65355
Currently we don't allow `keyword_marker` filter file resources to be reloaded via the `_reload_search_analyzers` API. It would make sense to allow reloading this when the file content has changed to allow e.g. for updating stemmer exeption rules at search time without having to close and re-open the index in question. This change adds the updateable flag to this token filter in the same way it is used for synonym filters. Analyzers containing updateable keyword_marker filters would not be allowed to be used at index time but at search time only, similar to what we allow for synonym filters. Closes elastic#65355
The keyword_marker filter allows for a
keyboard_path
configuration setting, but does not seem to support theupdateable
flag and thus cannot be reloaded via the reload search analyzers API.To reproduce create a
config/analysis/example_word_list.txt
file containingThen run the following in dev-tools
Another issue with this is, that anything can be configured in
my_custom_keyword_marker_filter
and thus setting/believing theupdateable
parameters works can be misleading.The text was updated successfully, but these errors were encountered: