Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

action.auto_create_index isn't a dynamic setting #7513

Closed
nik9000 opened this issue Aug 29, 2014 · 12 comments
Closed

action.auto_create_index isn't a dynamic setting #7513

nik9000 opened this issue Aug 29, 2014 · 12 comments
Assignees
@martijnvg
Labels
:Core/Infra/Settings Settings infrastructure and APIs >enhancement good first issue low hanging fruit help wanted adoptme

Comments

@nik9000
Copy link
Member

nik9000 commented Aug 29, 2014

Looks like action.auto_create_index can't be set dynamically as it isn't listed in ClusterDynamicSettingsModule.java. Any objection to me adding it?
@clintongormley
Copy link

Hmm - not sure this should be a dynamic setting...

@clintongormley
Copy link

@javanna any thoughts on this?

@javanna
Copy link
Member

javanna commented Sep 9, 2014

not sure either, it currently is a node level static setting, we could make it a cluster dynamic setting, but I think the rationale behind this choice was that one should not be able to change it dynamically. I'm conflicted here :)

@clintongormley
Copy link

@javanna my thinking exactly :)

Anybody else disagree? otherwise i think we should close this

@nik9000
Copy link
Member Author

nik9000 commented Sep 9, 2014

My reasoning for wanting it is that I tend to use it to prevent accidental index creation. My requirements changed slightly in that I have change it from a false to a whitelist pattern but if I can't change the pattern on the fly I have to schedule the change to go with the next rolling restart.

@clintongormley
Copy link

I wasn't aware that you could specify a pattern! This makes me lean more towards making it dynamic.

@bleskes
Copy link
Contributor

bleskes commented Sep 14, 2014

IMHO this should be dynamic. In my opinion this more of an error prevention feature than a security measure. We should opt for conveniance here for the operator. If you can call this end point you can create havoc anyway so i don't think we this plays as an argument here.

On Tue, Sep 9, 2014 at 4:23 PM, Clinton Gormley notifications@github.com
wrote:

I wasn't aware that you could specify a pattern! This makes me lean more towards making it dynamic.

Reply to this email directly or view it on GitHub:
#7513 (comment)

@synhershko
Copy link
Contributor

+1 for making this dynamic, at least if its on the pattern mode (and not just false)

@javanna javanna added the :Core/Infra/Settings Settings infrastructure and APIs label Mar 30, 2015
@pmusa
Copy link
Contributor

pmusa commented Feb 8, 2016

+1 for that as a dynamic setting. I am trying to set it in found and it is not possible currently.

@clintongormley clintongormley mentioned this issue Mar 31, 2016
Closed
@djschny
Copy link
Contributor

djschny commented Jun 5, 2016

+1 for this, it also helps avoid node level configuration inconsistency.

@frivoire
Copy link

(I'm fairly new to the ES world but) this setting seems more like a cluster-wide dynamic setting to me.

@itplayer
Copy link

I hope this setting can be a cluster-wide setting.
The reason is, if a node client setting is true(or lack of setting), but other nodes in cluster is false, then unexpected result happen.

@martijnvg martijnvg self-assigned this Aug 31, 2016
@martijnvg martijnvg mentioned this issue Sep 1, 2016
Merged
DaveCTurner added a commit to DaveCTurner/elasticsearch that referenced this issue Jan 27, 2019
@DaveCTurner
Document that auto_create_index is dynamic
85d90a5 
We changed the `action.auto_create_index` setting to be a dynamic cluster-level
setting in elastic#20274 but today the reference manual indicates that it is still a
static node-level setting. This commit addresses this, and clarifies the
semantics of patterns that may both permit and forbid the creation of certain
indices.

Relates elastic#7513
@DaveCTurner DaveCTurner mentioned this issue Jan 27, 2019
Merged
DaveCTurner added a commit that referenced this issue Jan 28, 2019
@DaveCTurner
Document that auto_create_index is dynamic (#37903)
2a610ab 
We changed the `action.auto_create_index` setting to be a dynamic cluster-level
setting in #20274 but today the reference manual indicates that it is still a
static node-level setting. This commit addresses this, and clarifies the
semantics of patterns that may both permit and forbid the creation of certain
indices.

Relates #7513
DaveCTurner added a commit that referenced this issue Jan 28, 2019
@DaveCTurner
Document that auto_create_index is dynamic (#37903)
2a864cb 
We changed the `action.auto_create_index` setting to be a dynamic cluster-level
setting in #20274 but today the reference manual indicates that it is still a
static node-level setting. This commit addresses this, and clarifies the
semantics of patterns that may both permit and forbid the creation of certain
indices.

Relates #7513, #27026
DaveCTurner added a commit that referenced this issue Jan 28, 2019
@DaveCTurner
Document that auto_create_index is dynamic (#37903)
8794fc5 
We changed the `action.auto_create_index` setting to be a dynamic cluster-level
setting in #20274 but today the reference manual indicates that it is still a
static node-level setting. This commit addresses this, and clarifies the
semantics of patterns that may both permit and forbid the creation of certain
indices.

Relates #7513, #27026
DaveCTurner added a commit that referenced this issue Jan 28, 2019
@DaveCTurner
Document that auto_create_index is dynamic (#37903)
8807f0c 
We changed the `action.auto_create_index` setting to be a dynamic cluster-level
setting in #20274 but today the reference manual indicates that it is still a
static node-level setting. This commit addresses this, and clarifies the
semantics of patterns that may both permit and forbid the creation of certain
indices.

Relates #7513, #27026
DaveCTurner added a commit that referenced this issue Jan 28, 2019
@DaveCTurner
Document that auto_create_index is dynamic (#37903)
6bd18db 
We changed the `action.auto_create_index` setting to be a dynamic cluster-level
setting in #20274 but today the reference manual indicates that it is still a
static node-level setting. This commit addresses this, and clarifies the
semantics of patterns that may both permit and forbid the creation of certain
indices.

Relates #7513, #27026
DaveCTurner added a commit that referenced this issue Jan 28, 2019
@DaveCTurner
Document that auto_create_index is dynamic (#37903)
a6a0bda 
We changed the `action.auto_create_index` setting to be a dynamic cluster-level
setting in #20274 but today the reference manual indicates that it is still a
static node-level setting. This commit addresses this, and clarifies the
semantics of patterns that may both permit and forbid the creation of certain
indices.

Relates #7513, #27026
DaveCTurner added a commit that referenced this issue Jan 28, 2019
@DaveCTurner
Document that auto_create_index is dynamic (#37903)
f2df48b 
We changed the `action.auto_create_index` setting to be a dynamic cluster-level
setting in #20274 but today the reference manual indicates that it is still a
static node-level setting. This commit addresses this, and clarifies the
semantics of patterns that may both permit and forbid the creation of certain
indices.

Relates #7513, #27026
DaveCTurner added a commit that referenced this issue Jan 28, 2019
@DaveCTurner
Document that auto_create_index is dynamic (#37903)
a48d525 
We changed the `action.auto_create_index` setting to be a dynamic cluster-level
setting in #20274 but today the reference manual indicates that it is still a
static node-level setting. This commit addresses this, and clarifies the
semantics of patterns that may both permit and forbid the creation of certain
indices.

Relates #7513, #27026
DaveCTurner added a commit that referenced this issue Jan 28, 2019
@DaveCTurner
Document that auto_create_index is dynamic (#37903)
09147a1 
We changed the `action.auto_create_index` setting to be a dynamic cluster-level
setting in #20274 but today the reference manual indicates that it is still a
static node-level setting. This commit addresses this, and clarifies the
semantics of patterns that may both permit and forbid the creation of certain
indices.

Relates #7513, #27026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@martijnvg martijnvg

Labels
:Core/Infra/Settings Settings infrastructure and APIs >enhancement good first issue low hanging fruit help wanted adoptme
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
10 participants
@clintongormley @djschny @synhershko @nik9000 @pmusa @martijnvg @javanna @bleskes @itplayer @frivoire