Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Aggregations: scripted metric agg does not separate parent buckets #8036

Closed
colings86 opened this issue Oct 9, 2014 · 0 comments · Fixed by #8037
Closed

Aggregations: scripted metric agg does not separate parent buckets #8036

colings86 opened this issue Oct 9, 2014 · 0 comments · Fixed by #8037
Assignees
@colings86
Labels
>bug v1.4.0 v1.5.0 v2.0.0-beta1

Comments

@colings86
Copy link
Contributor

The script metric aggregation does not separate script scopes based on the bucketOrd so when using it as a sub aggregation the results are given for all parent buckets combined rather than each parent bucket separately

See the following comment for more details:
#7075 (comment)
@colings86 colings86 self-assigned this Oct 9, 2014
This was referenced Oct 9, 2014
Merged
Merged
colings86 added a commit that referenced this issue Oct 10, 2014
@colings86
Aggregations: Fixes scripted metrics aggregation when used as a sub a…
f20ec6f 
…ggregation

The scripted metric aggregation is now a PER_BUCKET aggregation so that parent buckets are evaluated independently. Also the params and reduceParams are copied for each instance of the aggregator (each parent bucket) so modifications to the values are kept only within the scope of its parent bucket

Closes #8036
colings86 added a commit that referenced this issue Nov 3, 2014
@colings86
Aggregations: Fixes scripted metrics aggregation when used as a sub a…
fc28781 
…ggregation

The scripted metric aggregation is now a PER_BUCKET aggregation so that parent buckets are evaluated independently. Also the params and reduceParams are copied for each instance of the aggregator (each parent bucket) so modifications to the values are kept only within the scope of its parent bucket

Closes #8036
mute pushed a commit to mute/elasticsearch that referenced this issue Jul 29, 2015
@colings86
Aggregations: Fixes scripted metrics aggregation when used as a sub a…
03374b3 
…ggregation

The scripted metric aggregation is now a PER_BUCKET aggregation so that parent buckets are evaluated independently. Also the params and reduceParams are copied for each instance of the aggregator (each parent bucket) so modifications to the values are kept only within the scope of its parent bucket

Closes elastic#8036
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@colings86 colings86

Labels
>bug v1.4.0 v1.5.0 v2.0.0-beta1
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes scripted metrics aggregation when used as a sub aggregation
1 participant
@colings86