Mark GeoIpDownloaderTask as completed after cancellation #84028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
probakowski
added
>bug
:Data Management/Ingest Node
elasticmachine
added
the
Team:Data Management
|
Pinging @elastic/es-data-management (Team:Data Management) |
|
Hi @probakowski, I've created a changelog YAML for you. |
probakowski
added
the
auto-backport-and-merge
tlrx
reviewed
Feb 16, 2022
martijnvg
reviewed
Feb 16, 2022
There was a problem hiding this comment.
Production code change LGTM
I agree with @tlrx that we do need an integration test,
that verifies that the node tasks get cleaned up after
a new node task is started by persistent tasks framework.
(I think temporarily isolating the node that runs geoip
downloader task is a good idea to trigger this bug)
|
That makes sense, I'll add test case |
Adds the fields API for `dense_vector` field mapper. Adds a `DenseVector` interface for the value type. Implemented by: * `KnnDenseVector` which wraps a decoded float array from `VectorValues` * `BinaryDenseVector` which lazily decodes a `BytesRef` from `BinaryDocValues` The vector operations have moved into those implements from `BinaryDenseVectorScriptDocValues.java` and `KnnDenseVectorScriptDocValues.java`, respectively. The `DenseVector` API is: ``` float getMagnitude(); double dotProduct(float[] | List); double l1Norm(float[] | List); double l2Norm(float[] | List); float[] getVector(); int dims(); boolean isEmpty(); // does the value exist int size(); // 0 if isEmpty(), 1 otherwise Iterator<Float> iterator() ``` `dotProduct`, `l1Norm` and `l2Norm` take a `float[]` or a `List` via the a delegating `default` method on the `DenseVector` interface. The `DenseVectorDocValuesField` abstract class contains two getter APIS. It is implemented by `KnnDenseVectorDocValuesField` and `BinaryDenseVectorDocValuesField`. ``` DenseVector get() DenseVector get(DenseVector defaultValue) ``` The `get()` method is included because there isn't a good default dense vector, so that API returns an empty `DenseVector` which throws an `IllegalArgumentException` for all method calls other than `isEmpty()`, `size()` and `iterator()`. The empty dense vector will always be `DenseVector.EMPTY` in case users want to use equality checks. Refs: elastic#79105
If rolling upgrade was used from version prior GeoIPv2 (<`7.14`) then geoip downloader wouldn't be started so no new databases were downloaded. This is especially troubling in `8.x` as we no longer provide default databases inside ES so after upgrade no geoip enrichment can take place until downloader is started with workaround (setting `ingest.geoip.downloader.enabled` to `false` and `true` again). This is because logic that was used to lower number of requests / cluster update listeners at the startup was too optimistic about order of actions / who can be elected master at what time. This change fixes that and also cleans up logs when there are some ignorable errors and adds debug logging on start and stop of the task to ease up troubleshooting. It also adds rolling upgrade test to make sure the fix works.
ES 8+ requires JDK 17 to be built
bug Introduced by elastic#83835 This switches back our token tagging to take into account the tokens position when reconstituting and tagging tokens for NER.
This PR unmutes some tests that were muted for backporting elastic#83290
dakrone
pushed a commit
to dakrone/elasticsearch
that referenced
this pull request
Feb 28, 2022
Persistent task framework requires tasks to be marked either completed or failed after cancellation. This was missing in GeoIpDownloader
nik9000
pushed a commit
to nik9000/elasticsearch
that referenced
this pull request
Feb 28, 2022
Persistent task framework requires tasks to be marked either completed or failed after cancellation. This was missing in GeoIpDownloader
|
Looks like this is backport-pending (I've added the label) but note that it adds a flaky test which is currently muted in |
tlrx
pushed a commit
to tlrx/elasticsearch
that referenced
this pull request
Mar 3, 2022
Persistent task framework requires tasks to be marked either completed or failed after cancellation. This was missing in GeoIpDownloader
gmarouli
pushed a commit
to gmarouli/elasticsearch
that referenced
this pull request
Mar 16, 2022
Persistent task framework requires tasks to be marked either completed or failed after cancellation. This was missing in GeoIpDownloader
gmarouli
removed
backport pending
auto-backport-and-merge
|
Backport will be handled by #85014 |
gmarouli
added a commit
that referenced
this pull request
Mar 16, 2022
gmarouli
added a commit
to gmarouli/elasticsearch
that referenced
this pull request
Mar 16, 2022
elastic#85014) Persistent task framework requires tasks to be marked either completed or failed after cancellation. This was missing in GeoIpDownloader.
gmarouli
added a commit
to gmarouli/elasticsearch
that referenced
this pull request
Mar 16, 2022
elastic#85014) Persistent task framework requires tasks to be marked either completed or failed after cancellation. This was missing in GeoIpDownloader.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 16, 2022
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Persistent task framework requires tasks to be marked either completed or failed after cancellation. This was missing in
GeoIpDownloader