Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boolean field to support ignore_malformed #89542

Closed
javanna opened this issue Aug 23, 2022 · 14 comments
Closed

Boolean field to support ignore_malformed #89542

javanna opened this issue Aug 23, 2022 · 14 comments
Labels
>enhancement good first issue low hanging fruit help wanted adoptme :Search Foundations/Mapping Index mappings, including merging and defining field types Team:Search Meta label for search team

Comments

@javanna
Copy link
Member

javanna commented Aug 23, 2022

The ignore_malformed option is supported by a few of our field types, mainly numerics and dates, to still accept the document when such fields hold malformed values. See https://www.elastic.co/guide/en/elasticsearch/reference/current/ignore-malformed.html. Also ignore_malformed is an index level setting that gets applied to all field types that support it.

The boolean field type does not support ignore_malformed but it should, so that if a boolean field cannot be parsed as a boolean, the document can still be accepted.

@javanna javanna added >enhancement :Search Foundations/Mapping Index mappings, including merging and defining field types labels Aug 23, 2022
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search (Team:Search)

@elasticsearchmachine elasticsearchmachine added the Team:Search Meta label for search team label Aug 23, 2022
@javanna javanna added good first issue low hanging fruit help wanted adoptme labels Aug 23, 2022
@devnamrits
Copy link
Contributor

Hello @javanna, I would like to start my contribution to elasticsearch from this issue. Can I pick this up??

cc: @elasticsearchmachine

@javanna
Copy link
Member Author

javanna commented Aug 26, 2022

Yes @devnamrits thanks for offering your help, feel free to open a PR around this. let us know if you need guidance.

@devnamrits
Copy link
Contributor

Hi @javanna, Please assign this to me. I've built the project in my local and currently I'm going through the documentation. Also, it would be great if you can streamline things from the code point of view for this issue.

@akshaybhadange
Copy link

Hi @javanna , This is also my first contribution ,so do i need linux for contribution currently i am using windows

@javanna
Copy link
Member Author

javanna commented Sep 14, 2022

heya, I can't assign the issue to external contributors, but @devnamrits said he was interested a couple of weeks ago hence I would assume he will open a PR. @akshaybhadange I think it would be best to find another issue to work on to avoid overlap. here are some guidelines on contributing to the project: https://github.com/elastic/elasticsearch/blob/main/CONTRIBUTING.md#contributing-code-and-documentation-changes

@devnamrits
Copy link
Contributor

@javanna I've been working on it. I went through the test cases where you are testing the ignore_malformed. Can you please tell me where within code, ignore_malformed setting is enabled for currently supported data types. It would be really help as then I can deliver this fast if I get to know how { ignore_malformed: true } is being enabled for currently supporting data types.

@devnamrits
Copy link
Contributor

@javanna Raised PR for this issue. #90122

@javanna
Copy link
Member Author

javanna commented Sep 21, 2022

@devnamrits thanks, I've seen it, I will review it. It will take me a few days to get to it though, thanks for your patience.

@devnamrits
Copy link
Contributor

Hi @javanna Thank you for your kind reply. Let me know if changes are required.
Also it would be great, meanwhile, if you can assign me some other issue. Would love to pick them up.

@jem-n-em
Copy link

Hello, would you mind if I worked on this issue as well? This will be my first open source contribution of any sort; I am (hopefully-understandably) a little nervous about contributions, but this issue and the elasticsearch project look interesting to me.

@devnamrits
Copy link
Contributor

Hi @jem-n-em I've already raised PR for this. @javanna is reviewing. So @javanna can tell whether you should pick or not.

@jem-n-em
Copy link

jem-n-em commented Oct 1, 2022

Hi @jem-n-em I've already raised PR for this. @javanna is reviewing. So @javanna can tell whether you should pick or not.

oh I'm sorry, didn't see the conversation above, thank you anyways.

@khunt-miral
Copy link

Hi @javanna , I want to contribute in open source and I don't know from where to start so could you please help me to get started with open source and give any beginner friendly issues which I can solve.

saarikabhasi pushed a commit to saarikabhasi/elasticsearch that referenced this issue Apr 10, 2023
This PR enables the `ignore_malformed`parameter to be accepted as an option in 
boolean field mappings. Support for synthetic source is not added yet, so if
`ignore_malformed` is set to true, synthetic source isn't supported.

Closes elastic#89542
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>enhancement good first issue low hanging fruit help wanted adoptme :Search Foundations/Mapping Index mappings, including merging and defining field types Team:Search Meta label for search team
Projects
None yet
Development

No branches or pull requests

6 participants