Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Week Interval on Date Histogram Facet #904

Closed
rossini opened this issue May 4, 2011 · 5 comments

Comments

@rossini
Copy link

commented May 4, 2011

I think it would be very useful if we had a "week" interval on the date histogram facet with proper chronology handling. The interval value will be 1w or week.

@kimchy

This comment has been minimized.

Copy link
Member

commented May 4, 2011

There is one, just pass 1w in the interval.

@rossini

This comment has been minimized.

Copy link
Author

commented May 4, 2011

Got it, sorry for the issue, I was trying "w" and "week" with no success.

@rossini rossini closed this May 4, 2011

@kimchy

This comment has been minimized.

Copy link
Member

commented May 4, 2011

Got you, its not as good as month (time wise), as it simply does bucketing based on how long a week takes in milliseconds. I need to check if the timing library I use can do rounding based on weeks, then it might be simpler and more accurate.

@kimchy kimchy reopened this May 4, 2011

@kimchy

This comment has been minimized.

Copy link
Member

commented May 4, 2011

I will reopen, seems like there is good support for that (with proper week handling based on chronology).

@kimchy

This comment has been minimized.

Copy link
Member

commented May 4, 2011

ok, pushed support for it (forgot the closes handle in the commit message)

@kimchy kimchy closed this May 4, 2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.