Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Field data frequency filter value #9327

Closed
masaruh opened this issue Jan 16, 2015 · 2 comments · Fixed by #9522
Closed

Field data frequency filter value #9327

masaruh opened this issue Jan 16, 2015 · 2 comments · Fixed by #9522

Comments

@masaruh
Copy link
Contributor

masaruh commented Jan 16, 2015

According to document, max/min values can be specified as absolute number or percentage.

And according to this https://github.com/elasticsearch/elasticsearch/blob/master/src/main/java/org/elasticsearch/index/fielddata/plain/AbstractIndexOrdinalsFieldData.java#L118
, if a number is >= 1.0, it's considered as absolute number.

However, we often think 1.0 == 100%. Shouldn't it use ">" instead of ">="?
(By doing that, we won't be able to use min=1 as absolute number but it doesn't have any effect anyway)

In any case, adding document on this threshold would help.

@clintongormley
Copy link

Hi @masaruh

Good point. Would you be interested in sending a PR?

@masaruh
Copy link
Contributor Author

masaruh commented Feb 1, 2015

Yes, I'll create a PR.

masaruh added a commit to masaruh/elasticsearch that referenced this issue Feb 5, 2015
Make it consider 1.0 as 100% instead of aboslute count 1.

Closes: elastic#9327
@masaruh masaruh closed this as completed Feb 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants