Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESQL: incomplete parsing support for query params #99294

Closed
astefan opened this issue Sep 7, 2023 · 2 comments · Fixed by #99310
Closed

ESQL: incomplete parsing support for query params #99294

astefan opened this issue Sep 7, 2023 · 2 comments · Fixed by #99310
Assignees
Labels
:Analytics/ES|QL AKA ESQL >bug Team:QL (Deprecated) Meta label for query languages team

Comments

@astefan
Copy link
Contributor

astefan commented Sep 7, 2023

Description

For a query with params like "params": [{"x": 1}, {"y": 2}] running in a JVM with assertions disabled results in:

  "error": {
    "root_cause": [
      {
        "type": "x_content_parse_exception",
        "reason": "Failed to build [params] after last required field arrived"
      }
    ],
    "type": "x_content_parse_exception",
    "reason": "[3:19] [esql/query] failed to parse field [params]",
    "caused_by": {
      "type": "x_content_parse_exception",
      "reason": "Failed to build [params] after last required field arrived",
      "caused_by": {
        "type": "array_index_out_of_bounds_exception",
        "reason": "Index 1 out of bounds for length 0"
      }
    }
  }

but with assertions enabled:

[2023-09-07T13:03:21,434][ERROR][o.e.b.ElasticsearchUncaughtExceptionHandler] [runTask-0] fatal error in thread [Thread-2], exiting java.lang.AssertionError: [params] must configure at least one constructor argument. If it doesn't have any it should use ObjectParser instead of ConstructingObjectParser. This is a bug in the parser declaration.
┬╗      at org.elasticsearch.xcontent@8.11.0-SNAPSHOT/org.elasticsearch.xcontent.ConstructingObjectParser$Target.finish(ConstructingObjectParser.java:543)
┬╗      at org.elasticsearch.xcontent@8.11.0-SNAPSHOT/org.elasticsearch.xcontent.ConstructingObjectParser.parse(ConstructingObjectParser.java:166)
┬╗      at org.elasticsearch.xcontent@8.11.0-SNAPSHOT/org.elasticsearch.xcontent.ConstructingObjectParser.apply(ConstructingObjectParser.java:158)
┬╗      at org.elasticsearch.xpack.esql.action.EsqlQueryRequest.parseParams(EsqlQueryRequest.java:181)
┬╗      at org.elasticsearch.xcontent@8.11.0-SNAPSHOT/org.elasticsearch.xcontent.AbstractObjectParser.lambda$declareField$0(AbstractObjectParser.java:174)
┬╗      at org.elasticsearch.xcontent@8.11.0-SNAPSHOT/org.elasticsearch.xcontent.ObjectParser.lambda$declareField$10(ObjectParser.java:431)
┬╗      at org.elasticsearch.xcontent@8.11.0-SNAPSHOT/org.elasticsearch.xcontent.ObjectParser.parseValue(ObjectParser.java:609)
┬╗      at org.elasticsearch.xcontent@8.11.0-SNAPSHOT/org.elasticsearch.xcontent.ObjectParser.parseArray(ObjectParser.java:604)
┬╗      at org.elasticsearch.xcontent@8.11.0-SNAPSHOT/org.elasticsearch.xcontent.ObjectParser.parseSub(ObjectParser.java:643)
┬╗      at org.elasticsearch.xcontent@8.11.0-SNAPSHOT/org.elasticsearch.xcontent.ObjectParser.parse(ObjectParser.java:315)
┬╗      at org.elasticsearch.xcontent@8.11.0-SNAPSHOT/org.elasticsearch.xcontent.ObjectParser.parse(ObjectParser.java:259)
┬╗      at org.elasticsearch.xcontent@8.11.0-SNAPSHOT/org.elasticsearch.xcontent.ObjectParser.apply(ObjectParser.java:382)
┬╗      at org.elasticsearch.xpack.esql.action.EsqlQueryRequest.fromXContent(EsqlQueryRequest.java:144)
┬╗      at org.elasticsearch.xpack.esql.action.RestEsqlQueryAction.prepareRequest(RestEsqlQueryAction.java:45)
@elasticsearchmachine elasticsearchmachine added the Team:QL (Deprecated) Meta label for query languages team label Sep 7, 2023
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-ql (Team:QL)

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/elasticsearch-esql (:Query Languages/ES|QL)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/ES|QL AKA ESQL >bug Team:QL (Deprecated) Meta label for query languages team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants