Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESQL: "params" correctly parses the values including an optional "type" #99310

Merged
merged 2 commits into from Sep 8, 2023

Conversation

astefan
Copy link
Contributor

@astefan astefan commented Sep 7, 2023

Fixes #99294.
It's also supporting an optional type & value combination:

{
  "query": "from test | eval x = ?, y = ?",
  "params": [{"type": "double", "value": 12345}, "abc"]
}

@elasticsearchmachine elasticsearchmachine added the Team:QL (Deprecated) Meta label for query languages team label Sep 7, 2023
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-ql (Team:QL)

@elasticsearchmachine
Copy link
Collaborator

Hi @astefan, I've created a changelog YAML for you.

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/elasticsearch-esql (:Query Languages/ES|QL)

Copy link
Contributor

@luigidellaquila luigidellaquila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@costin costin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@astefan astefan merged commit b08f1e4 into elastic:main Sep 8, 2023
12 checks passed
@astefan astefan deleted the fix_99294 branch September 8, 2023 07:21
alex-spies pushed a commit to dreamquster/elasticsearch that referenced this pull request Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/ES|QL AKA ESQL >bug ES|QL-ui Impacts ES|QL UI Team:QL (Deprecated) Meta label for query languages team v8.11.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ESQL: incomplete parsing support for query params
4 participants