Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ProjectTests fails on some seed #99982

Closed
nik9000 opened this issue Sep 27, 2023 · 4 comments · Fixed by #99991
Closed

ProjectTests fails on some seed #99982

nik9000 opened this issue Sep 27, 2023 · 4 comments · Fixed by #99991
Assignees
@ChrisHegarty
Labels
:Analytics/ES|QL AKA ESQL Team:QL (Deprecated) Meta label for query languages team >test Issues or PRs that are addressing/adding tests >test-failure Triaged test failures from CI v8.11.0

Comments

@nik9000
Copy link
Member

nik9000 commented Sep 27, 2023

CI Link

local

Repro line

./gradlew ':x-pack:plugin:esql:compute:test' --tests "org.elasticsearch.compute.operator.ProjectOperatorTests.testProjection" -Dtests.seed=91943554DA6E3559 -Dtests.locale=ar-SA -Dtests.timezone=Indian/Comoro -Druntime.java=21

Does it reproduce?

Yes

Applicable branches

main

Failure history

No response

Failure excerpt

  2> java.lang.AssertionError: java.lang.IllegalStateException: can't release already released block [IntVectorBlock[vector=ConstantIntVector[positions=3, value=0]]]
        at __randomizedtesting.SeedInfo.seed([91943554DA6E3559:69BE85F199AA9B5]:0)
        at org.elasticsearch.core.Releasables.closeExpectNoException(Releasables.java:49)
        at org.elasticsearch.compute.data.Page.releaseBlocks(Page.java:224)
        at org.elasticsearch.compute.operator.ProjectOperatorTests.testProjection(ProjectOperatorTests.java:79)

        Caused by:
        java.lang.IllegalStateException: can't release already released block [IntVectorBlock[vector=ConstantIntVector[positions=3, value=0]]]
            at org.elasticsearch.compute.data.IntVectorBlock.close(IntVectorBlock.java:76)
            at org.elasticsearch.core.IOUtils.close(IOUtils.java:71)
            at org.elasticsearch.core.IOUtils.close(IOUtils.java:87)
            at org.elasticsearch.core.IOUtils.close(IOUtils.java:63)
            at org.elasticsearch.core.Releasables.close(Releasables.java:73)
            at org.elasticsearch.core.Releasables.close(Releasables.java:41)
            at org.elasticsearch.core.Releasables.closeExpectNoException(Releasables.java:47)
            ... 2 more

I'm unsure if the test is generating sensible projection configurations. This may be an invalid thing.
@nik9000 nik9000 added >test-failure Triaged test failures from CI needs:triage Requires assignment of a team area label >test Issues or PRs that are addressing/adding tests :Analytics/ES|QL AKA ESQL v8.11.0 and removed needs:triage Requires assignment of a team area label labels Sep 27, 2023
@elasticsearchmachine elasticsearchmachine added the Team:QL (Deprecated) Meta label for query languages team label Sep 27, 2023
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-ql (Team:QL)

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/elasticsearch-esql (:Query Languages/ES|QL)

@jakelandis
Copy link
Contributor

Also failed in a PR build : https://gradle-enterprise.elastic.co/s/eylbtwkdrctq6/tests/task/:x-pack:plugin:esql:compute:test/details/org.elasticsearch.compute.operator.ProjectOperatorTests/testProjection?top-execution=1

REPRODUCE WITH: ./gradlew ':x-pack:plugin:esql:compute:test' --tests "org.elasticsearch.compute.operator.ProjectOperatorTests.testProjection" -Dtests.seed=D4C73589E0FAB04A -Dtests.locale=nb-NO -Dtests.timezone=America/Montevideo -Druntime.java=21 |  

@jakelandis jakelandis mentioned this issue Sep 27, 2023
Merged
@costin costin mentioned this issue Sep 28, 2023
Merged
costin added a commit that referenced this issue Sep 28, 2023
@costin
ESQL: Ignore exception when closing blocks inside a page (#99991)
292722d 
Fix #99982
@costin costin mentioned this issue Sep 28, 2023
Closed
piergm pushed a commit to piergm/elasticsearch that referenced this issue Oct 2, 2023
@costin @piergm
ESQL: Ignore exception when closing blocks inside a page (elastic#99991)
7c3cc00 
Fix elastic#99982
@costin
Copy link
Member

costin commented Oct 9, 2023

Should be fixed by #100370

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ChrisHegarty ChrisHegarty

Labels
:Analytics/ES|QL AKA ESQL Team:QL (Deprecated) Meta label for query languages team >test Issues or PRs that are addressing/adding tests >test-failure Triaged test failures from CI v8.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ESQL: Ignore exception when closing blocks inside a page elastic/elasticsearch
5 participants
@costin @nik9000 @jakelandis @elasticsearchmachine @ChrisHegarty