Validate enrich index before completing policy execution #100106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbaiera
added
>bug
:Data Management/Ingest Node
elasticsearchmachine
added
the
Team:Data Management
|
Pinging @elastic/es-data-management (Team:Data Management) |
|
Hi @jbaiera, I've created a changelog YAML for you. |
💔 Backport failed
You can use sqren/backport to manually backport by running |
jbaiera
added a commit
that referenced
this pull request
Oct 2, 2023
Build failures seem to be related to #100106 being based on a stale view of main
jbaiera
added a commit
to jbaiera/elasticsearch
that referenced
this pull request
Oct 2, 2023
) This PR adds a validation step to the end of an enrich policy run to ensure the integrity of the enrich index that is about to be promoted. (cherry picked from commit 225db31) # Conflicts: # x-pack/plugin/enrich/src/main/java/org/elasticsearch/xpack/enrich/EnrichPolicyRunner.java # x-pack/plugin/enrich/src/test/java/org/elasticsearch/xpack/enrich/EnrichPolicyRunnerTests.java
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
jbaiera
added a commit
to jbaiera/elasticsearch
that referenced
this pull request
Oct 2, 2023
) This PR adds a validation step to the end of an enrich policy run to ensure the integrity of the enrich index that is about to be promoted. (cherry picked from commit 225db31) # Conflicts: # x-pack/plugin/enrich/src/main/java/org/elasticsearch/xpack/enrich/EnrichPolicyRunner.java # x-pack/plugin/enrich/src/test/java/org/elasticsearch/xpack/enrich/EnrichPolicyRunnerTests.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases it is possible for the enrich index being constructed by an executing policy to be deleted. In the event that this happens, there is a chance that the index will be recreated incorrectly. In some cases this can lead to an incomplete enrich index to be promoted to the current index. This PR adds a validation step to the end of an enrich policy run to ensure the integrity of the enrich index that is about to be promoted.
Relates to #99725 but further changes will be needed to fully close that issue.