Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor SearchResponseClusters to use CHM #100129

Merged
merged 13 commits into from Oct 3, 2023
Merged

Refactor SearchResponseClusters to use CHM #100129

merged 13 commits into from Oct 3, 2023

Conversation

piergm
Copy link
Member

@piergm piergm commented Oct 2, 2023

Swapped Map<String, AtomicReference<Cluster>> with
ConcurrentHashMap<String, Cluster> in order to avoid
Compare-and-Swap loops.

Closes #99101

@piergm piergm added >enhancement :Search/Search Search-related issues that do not fall into other categories Team:Search Meta label for search team v8.11.0 labels Oct 2, 2023
@piergm piergm self-assigned this Oct 2, 2023
@elasticsearchmachine
Copy link
Collaborator

Hi @piergm, I've created a changelog YAML for you.

@piergm piergm marked this pull request as ready for review October 2, 2023 15:03
@piergm piergm requested review from quux00 and javanna October 2, 2023 15:03
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search (Team:Search)

@piergm piergm mentioned this pull request Oct 2, 2023
Closed
@piergm
Copy link
Member Author

piergm commented Oct 2, 2023

Original comment https://github.com/elastic/elasticsearch/pull/98457/files#r1310467586

quux00
quux00 approved these changes Oct 3, 2023
View reviewed changes
Copy link
Contributor

@quux00 quux00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work on this. LGTM!

@piergm piergm added the auto-merge Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Oct 3, 2023
@elasticsearchmachine elasticsearchmachine merged commit 608bb02 into elastic:main Oct 3, 2023
12 checks passed
@piergm piergm deleted the refactor-searchResponseCluster-to-use-CHM branch October 3, 2023 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quux00 quux00 quux00 approved these changes

@javanna javanna Awaiting requested review from javanna

@original-brownbear original-brownbear Awaiting requested review from original-brownbear

Assignees

@piergm piergm

Labels
auto-merge Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) >enhancement :Search/Search Search-related issues that do not fall into other categories Team:Search Meta label for search team v8.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor SearchResponse.Clusters to use ConcurrentHashMap for immutable Cluster object swaps
3 participants
@piergm @elasticsearchmachine @quux00