New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ILM introduce the check-ts-end-time-passed
step
#100179
ILM introduce the check-ts-end-time-passed
step
#100179
Conversation
This introduce a new ILM step, the `check-ts-end-time-passed` step that'll wait for the `index.time_series.end_time` to lapse for TS indices before allowing ILM to proceed with the execution of the following actions: * downsample * forcemerge * readonly * searchable_snapshot * shrink TSDS indices are allowed to receive writes until the configured `index.time_series.end_time` time passes. This makes sure ILM doesn't block these indices from accepting writes prematurely.
Hi @andreidan, I've created a changelog YAML for you. |
Pinging @elastic/es-data-management (Team:Data Management) |
@elasticmachine run elasticsearch-ci/part-1 |
@elasticmachine run elasticsearch-ci/part-2 Failure tracked already in #96723 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left one testing comment. LGTM otherwise.
} | ||
Instant configuredEndTime = IndexSettings.TIME_SERIES_END_TIME.get(indexMetadata.getSettings()); | ||
assert configuredEndTime != null : "a time series index must have an end time configured but [" + index.getName() + "] does not"; | ||
if (Instant.now().isBefore(configuredEndTime)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe provide current time as a lambda function? This would allow unit tests to not rely on current time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes! Great shout. Done in a6ffc7d
Thanks Martijn
@elasticmachine run elasticsearch-ci/part-3 |
This introduces a new ILM step, the `check-ts-end-time-passed` step that'll wait for the `index.time_series.end_time` to lapse for TS indices before allowing ILM to proceed with the execution of the following actions: * downsample * forcemerge * readonly * searchable_snapshot * shrink TSDS indices are allowed to receive writes until the configured `index.time_series.end_time` time passes. This makes sure ILM doesn't block these indices from accepting writes prematurely. NOTE: documentation is added in a subsequent PR Fixes elastic#99696 (cherry picked from commit 8bf8fc1) Signed-off-by: Andrei Dan <andrei.dan@elastic.co>
This introduces a new ILM step, the `check-ts-end-time-passed` step that'll wait for the `index.time_series.end_time` to lapse for TS indices before allowing ILM to proceed with the execution of the following actions: * downsample * forcemerge * readonly * searchable_snapshot * shrink TSDS indices are allowed to receive writes until the configured `index.time_series.end_time` time passes. This makes sure ILM doesn't block these indices from accepting writes prematurely. NOTE: documentation is added in a subsequent PR Fixes elastic#99696
💚 Backport successful
|
This introduces a new ILM step, the `check-ts-end-time-passed` step that'll wait for the `index.time_series.end_time` to lapse for TS indices before allowing ILM to proceed with the execution of the following actions: * downsample * forcemerge * readonly * searchable_snapshot * shrink TSDS indices are allowed to receive writes until the configured `index.time_series.end_time` time passes. This makes sure ILM doesn't block these indices from accepting writes prematurely. NOTE: documentation is added in a subsequent PR Fixes #99696
This introduces a new ILM step, the `check-ts-end-time-passed` step that'll wait for the `index.time_series.end_time` to lapse for TS indices before allowing ILM to proceed with the execution of the following actions: * downsample * forcemerge * readonly * searchable_snapshot * shrink TSDS indices are allowed to receive writes until the configured `index.time_series.end_time` time passes. This makes sure ILM doesn't block these indices from accepting writes prematurely. NOTE: documentation is added in a subsequent PR Fixes #99696 (cherry picked from commit 8bf8fc1) Signed-off-by: Andrei Dan <andrei.dan@elastic.co>
This introduces a new ILM step, the
check-ts-end-time-passed
step that'll wait for theindex.time_series.end_time
to lapse for TS indices before allowing ILM to proceed with the execution of the following actions:TSDS indices are allowed to receive writes until the configured
index.time_series.end_time
time passes. This makes sure ILM doesn't block these indices from accepting writes prematurely.NOTE: documentation is added in a subsequent PR
Fixes #99696