Search of remote clusters with no shards results in successful status. #100354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccs_minimize_roundtrips=true was not checking if no shards were present to search before setting the cluster search status. If number of shards is zero, then cluster search status should be zero. This aligns ccs_minimize_roundtrips=true with the false setting and how it worked in earlier versions. Fixes bug elastic#100350
quux00
added
>bug
:Search/Search
|
Pinging @elastic/es-search (Team:Search) |
|
Hi @quux00, I've created a changelog YAML for you. |
|
@quux00 Can we backport this to the next 8.10 and 8.11 patches? |
droberts195
added
v8.11.0
v8.10.4
auto-backport-and-merge
|
Since this problem has such a big impact on ML datafeeds used within a large CCS environment I propose that this fix should be backported to 8.11 and 8.10. I've added the relevant labels, so if the changes backport cleanly hopefully this will involve no extra effort. Let me know if you disagree. |
quux00
added a commit
to quux00/elasticsearch
that referenced
this pull request
Oct 6, 2023
elastic#100354) ccs_minimize_roundtrips=true was not checking if no shards were present to search before setting the cluster search status. If the number of shards is zero, then cluster search status should be 'successful'. This aligns ccs_minimize_roundtrips=true with the false setting and how it worked in earlier versions. Fixes bug elastic#100350
💔 Backport failed
You can use sqren/backport to manually backport by running |
quux00
added a commit
to quux00/elasticsearch
that referenced
this pull request
Oct 6, 2023
elastic#100354) ccs_minimize_roundtrips=true was not checking if no shards were present to search before setting the cluster search status. If the number of shards is zero, then cluster search status should be 'successful'. This aligns ccs_minimize_roundtrips=true with the false setting and how it worked in earlier versions. Fixes bug elastic#100350
elasticsearchmachine
pushed a commit
that referenced
this pull request
Oct 6, 2023
#100354) (#100442) ccs_minimize_roundtrips=true was not checking if no shards were present to search before setting the cluster search status. If the number of shards is zero, then cluster search status should be 'successful'. This aligns ccs_minimize_roundtrips=true with the false setting and how it worked in earlier versions. Fixes bug #100350
quux00
added a commit
to quux00/elasticsearch
that referenced
this pull request
Oct 6, 2023
elastic#100354) ccs_minimize_roundtrips=true was not checking if no shards were present to search before setting the cluster search status. If the number of shards is zero, then cluster search status should be 'successful'. This aligns ccs_minimize_roundtrips=true with the false setting and how it worked in earlier versions. Fixes bug elastic#100350
|
Manual backport to 8.10 here: #100458 |
quux00
added a commit
that referenced
this pull request
Oct 6, 2023
#100354) (#100458) ccs_minimize_roundtrips=true was not checking if no shards were present to search before setting the cluster search status. If the number of shards is zero, then cluster search status should be 'successful'. This aligns ccs_minimize_roundtrips=true with the false setting and how it worked in earlier versions. Backported from #100354 Fixes bug #100350
|
The 8.11 and 8.10 backports have been completed, so it should be in ES releases for 8.10.4 and 8.11.1 and 8.12.0. |
|
Removing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ccs_minimize_roundtrips=true was not checking if no shards were present to
search before setting the cluster search status. If number of shards is zero,
then cluster search status should be successful. This aligns ccs_minimize_roundtrips=true
with the false setting and how it worked in earlier versions.
Fixes bug #100350