DSL waits for the tsdb time boundaries to lapse #100470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TSDB indices are expected to receive a large amounts of writes whilst their time bounds are "active" (i.e they include `now`). This ensures TSDB doesn't execute any ingest disruptive operations (like delete, forcemerge, downsample) until the `end_time` for the TSDS backing indices has lapsed.
andreidan
added
>bug
:Data Management/Data streams
elasticsearchmachine
added
the
Team:Data Management
|
Pinging @elastic/es-data-management (Team:Data Management) |
|
Hi @andreidan, I've created a changelog YAML for you. |
|
@elasticmachine update branch |
masseyke
approved these changes
Oct 10, 2023
There was a problem hiding this comment.
As we discussed offline, the code changes look great to me. We don't actually have any integration test coverage though (the changes to integration tests are just to get them compiling). It would be fairly hard to integration test this. I assume we could do something that would artificially get some TSDB indices in the state we want, and then do a test something like DataStreamLifecycleServiceIT.testAutomaticForceMerge(), but I don't know how to do that, or if it is even possible.
andreidan
added
the
auto-backport-and-merge
💚 Backport successful
|
andreidan
added a commit
to andreidan/elasticsearch
that referenced
this pull request
Oct 11, 2023
TSDB indices are expected to receive a large amounts of writes whilst their time bounds are "active" (i.e they include `now`). This ensures TSDB doesn't execute any ingest disruptive operations (like delete, forcemerge, downsample) until the `end_time` for the TSDS backing indices has lapsed.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Oct 11, 2023
TSDB indices are expected to receive a large amounts of writes whilst their time bounds are "active" (i.e they include `now`). This ensures TSDB doesn't execute any ingest disruptive operations (like delete, forcemerge, downsample) until the `end_time` for the TSDS backing indices has lapsed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TSDB indices are expected to receive a large amount of writes whilst their time bounds are "active" (i.e. they include
now). This ensures TSDB doesn't execute any ingest disruptive operations (like delete, forcemerge, downsample) until theend_timefor the TSDS backing indices has lapsed.Fixes #99696