New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Grant editor and viewer access to profiling #100594
Merged
danielmitterdorfer
merged 2 commits into
elastic:main
from
danielmitterdorfer:add-profiling-to-viewer
Oct 13, 2023
Merged
Grant editor and viewer access to profiling #100594
danielmitterdorfer
merged 2 commits into
elastic:main
from
danielmitterdorfer:add-profiling-to-viewer
Oct 13, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this commit we amend the `viewer` and `editor` roles so that access to the index patterns related to Universal Profiling is possible. The `editor` role gets the same permissions as `viewer` for these index patterns because it does not make sense to write to these indices directly (i.e. instead of the collector / symbolizer doing that).
danielmitterdorfer
added
>bug
:Security/Authorization
Roles, Privileges, DLS/FLS, RBAC/ABAC
auto-backport-and-merge
Automatically create backport pull requests and merge when ready
v8.11.0
test-update-serverless
v8.12.0
v8.10.4
labels
Oct 10, 2023
Hi @danielmitterdorfer, I've created a changelog YAML for you. |
Pinging @elastic/es-security (Team:Security) |
jakelandis
approved these changes
Oct 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (also sent a message over slack)
💚 Backport successful
|
danielmitterdorfer
added a commit
to danielmitterdorfer/elasticsearch
that referenced
this pull request
Oct 13, 2023
With this commit we amend the `viewer` and `editor` roles so that access to the index patterns related to Universal Profiling is possible. The `editor` role gets the same permissions as `viewer` for these index patterns because it does not make sense to write to these indices directly (i.e. instead of the collector / symbolizer doing that).
elasticsearchmachine
pushed a commit
that referenced
this pull request
Oct 13, 2023
With this commit we amend the `viewer` and `editor` roles so that access to the index patterns related to Universal Profiling is possible. The `editor` role gets the same permissions as `viewer` for these index patterns because it does not make sense to write to these indices directly (i.e. instead of the collector / symbolizer doing that).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
auto-backport-and-merge
Automatically create backport pull requests and merge when ready
>bug
:Security/Authorization
Roles, Privileges, DLS/FLS, RBAC/ABAC
Team:Security
Meta label for security team
test-update-serverless
v8.11.0
v8.12.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this commit we amend the
viewer
andeditor
roles so that access to the index patterns related to Universal Profiling is possible. Theeditor
role gets the same permissions asviewer
for these index patterns because it does not make sense to write to these indices directly (i.e. instead of the collector / symbolizer doing that).