Make S3 anti-contention delay configurable #101245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The anti-contention delay in the S3 repository's compare-and-exchange operation is hard-coded at 1 second today, but sometimes we encounter a repository that needs much longer to perform a compare-and-exchange operation when under contention. With this commit we make the anti-contention delay configurable.
DaveCTurner
added
>bug
:Distributed/Snapshot/Restore
|
Pinging @elastic/es-distributed (Team:Distributed) |
|
Hi @DaveCTurner, I've created a changelog YAML for you. |
ywangd
approved these changes
Oct 23, 2023
Comment on lines
+63
to
+68
| private static final Setting<TimeValue> REPOSITORY_S3_CAS_ANTI_CONTENTION_DELAY_SETTING = Setting.timeSetting( | ||
| "repository_s3.compare_and_exchange.anti_contention_delay", | ||
| TimeValue.timeValueSeconds(1), | ||
| TimeValue.timeValueMillis(1), | ||
| TimeValue.timeValueHours(24), | ||
| Setting.Property.NodeScope |
There was a problem hiding this comment.
Do we want this setting to be dynamic updatable?
There was a problem hiding this comment.
I think no (at least not for now).
idegtiarenko
approved these changes
Oct 24, 2023
fcofdez
approved these changes
Oct 24, 2023
DaveCTurner
added
the
auto-backport-and-merge
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Oct 24, 2023
The anti-contention delay in the S3 repository's compare-and-exchange operation is hard-coded at 1 second today, but sometimes we encounter a repository that needs much longer to perform a compare-and-exchange operation when under contention. With this commit we make the anti-contention delay configurable.
💚 Backport successful
|
elasticsearchmachine
pushed a commit
that referenced
this pull request
Oct 24, 2023
The anti-contention delay in the S3 repository's compare-and-exchange operation is hard-coded at 1 second today, but sometimes we encounter a repository that needs much longer to perform a compare-and-exchange operation when under contention. With this commit we make the anti-contention delay configurable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The anti-contention delay in the S3 repository's compare-and-exchange
operation is hard-coded at 1 second today, but sometimes we encounter a
repository that needs much longer to perform a compare-and-exchange
operation when under contention. With this commit we make the
anti-contention delay configurable.