Remove Plugin.createComponents method that specifies individual services #101457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thecoop
added
:Core/Infra/Plugins
elasticsearchmachine
added
Team:Core/Infra
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
ldematte
approved these changes
Oct 27, 2023
|
I'd suggest a small change to the "breaking change" message. While it would be a breaking change for a lot of plugins, plugins aren't required to override Rather, I'd specify that it's a breaking change for any plugin that overrides I hope I'm not coming off as pedantic. Mainly I don't want to accidentally imply that we're breaking the stability guarantee for stable plugins when we're not actually doing that. |
|
I've tweaked the changelog wording |
mark-vieira
pushed a commit
to mark-vieira/elasticsearch
that referenced
this pull request
Nov 2, 2023
…ces (elastic#101457) This is a breaking change for plugins implementing createComponents. Subclasses should be refactored to implement the method that takes a PluginServices object instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the
createComponentsmethod that specifies individual services, in favour of thePluginServicesmethod.This is a breaking change for all plugin implementations; implementations should move to the
createComponents(PluginServices)method