ESQL: More tracking in BlockHash impls #101488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds memory tracking to more parts of the `BlockHash` implementations. It also reworks the tests so they assert based on callbacks which is more like how they are used in production.
elasticsearchmachine
added
the
Team:Analytics
|
Pinging @elastic/es-analytics-geo (Team:Analytics) |
|
Hi @nik9000, I've created a changelog YAML for you. |
dnhatn
approved these changes
Oct 28, 2023
| @@ -75,7 +75,7 @@ private IntBlock add(BooleanBlock block) { | |||
|
|
|||
| @Override | |||
| public BooleanBlock[] getKeys() { | |||
| BooleanBlock.Builder builder = BooleanBlock.newBlockBuilder(everSeen.length); | |||
| BooleanBlock.Builder builder = blockFactory.newBooleanBlockBuilder(everSeen.length); | |||
| @@ -90,7 +90,7 @@ public BooleanBlock[] getKeys() { | |||
|
|
|||
| @Override | |||
| public IntVector nonEmpty() { | |||
| IntVector.Builder builder = IntVector.newVectorBuilder(everSeen.length); | |||
| IntVector.Builder builder = blockFactory.newIntVectorBuilder(everSeen.length); | |||
| keyBlocks[g] = builders[g].build(); | ||
| } | ||
| } finally { | ||
| if (keyBlocks[keyBlocks.length - 1] == null) { |
…blockhash' into esql_track_unused_blockhash
nik9000
added
the
auto-merge
mark-vieira
pushed a commit
to mark-vieira/elasticsearch
that referenced
this pull request
Nov 2, 2023
This adds memory tracking to more parts of the `BlockHash` implementations. It also reworks the tests so they assert based on callbacks which is more like how they are used in production.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds memory tracking to more parts of the
BlockHashimplementations. It also reworks the tests so they assert based on callbacks which is more like how they are used in production.