Add an additional tiebreaker to RRF #101847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/es-search (Team:Search) |
|
Hi @jdconrad, I've created a changelog YAML for you. |
mayya-sharipova
approved these changes
Nov 7, 2023
|
Thank you for the review, @mayya-sharipova! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds an additional tiebreaker for RRF where when two documents have the same RRF "score" such as identical ranks of (3,4) and (4,3) or (1,-) and (-,1), etc. the ordering will fallback to the highest score from query 1 then query 2, and so on. If all scores are equal then the tiebreaker will be shard index followed by doc id, but these are not necessarily stable. This should resolve most of the stability issues outlined as part of (#101232).
Closes #101232