Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust SortField comparators to use new Pruning API #101983

Merged
merged 3 commits into from
Nov 9, 2023
Merged

Adjust SortField comparators to use new Pruning API #101983

merged 3 commits into from
Nov 9, 2023

Conversation

benwtrent
Copy link
Member

Introduced in apache/lucene#12405

We should account for the changes in our overrides and API. Now, to indicate that no skipping can occur, we utilize Pruning.NONE.

@benwtrent benwtrent added >non-issue :Search/Search Search-related issues that do not fall into other categories v8.12.0 labels Nov 9, 2023
@elasticsearchmachine elasticsearchmachine added the Team:Search Meta label for search team label Nov 9, 2023
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search (Team:Search)

javanna
javanna approved these changes Nov 9, 2023
View reviewed changes
Copy link
Member

@javanna javanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for fixing!

@benwtrent benwtrent merged commit 3f9ab8a into elastic:lucene_snapshot Nov 9, 2023
13 checks passed
@benwtrent benwtrent deleted the fix-compilation branch November 9, 2023 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javanna javanna javanna approved these changes

Assignees
No one assigned
Labels
>non-issue :Search/Search Search-related issues that do not fall into other categories Team:Search Meta label for search team v8.12.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@benwtrent @elasticsearchmachine @javanna