Resolve compile error in DenseVectorFieldMapper #102066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A change in Lucene99HnswVectorsFormat requires that we adapt our code, see apache/lucene#12729
javanna
added
>non-issue
:Search/Search
|
Pinging @elastic/es-search (Team:Search) |
benwtrent
approved these changes
Nov 13, 2023
benwtrent
reviewed
Nov 13, 2023
| @@ -76,7 +76,10 @@ public enum LuceneFilesExtensions { | |||
| // kNN vectors format | |||
| VEC("vec", "Vector Data", false, true), | |||
| VEX("vex", "Vector Index", false, true), | |||
| VEM("vem", "Vector Metadata", true, false); | |||
| VEM("vem", "Vector Metadata", true, false), | |||
There was a problem hiding this comment.
@javanna there are new file extensions we need to be aware of. I added them here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A change in Lucene99HnswVectorsFormat requires that we adapt our code, see apache/lucene#12729