Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

default run_ml_inference should be true #102151

Merged
merged 2 commits into from Nov 14, 2023
Merged

default run_ml_inference should be true #102151

merged 2 commits into from Nov 14, 2023

Conversation

seanstory
Copy link
Member

@seanstory seanstory commented Nov 14, 2023

Part of https://elasticco.atlassian.net/browse/SEARCH-101

Seems that the default was incorrectly copied when these mapping definitions were moved over from ent-search

Seems that the default was incorrectly copied when these mapping definitions were moved over from ent-search
@seanstory seanstory added auto-backport Automatically create backport pull requests when merged v8.11.1 v8.12.0 v8.10.5 labels Nov 14, 2023
@elasticsearchmachine elasticsearchmachine added the needs:triage Requires assignment of a team area label label Nov 14, 2023
@seanstory seanstory added Team:Enterprise Search Meta label for Enterprise Search team >bug labels Nov 14, 2023
@elasticsearchmachine elasticsearchmachine removed the Team:Enterprise Search Meta label for Enterprise Search team label Nov 14, 2023
Copy link
Contributor

@demjened demjened left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TattdCodeMonkey TattdCodeMonkey added the Team:Enterprise Search Meta label for Enterprise Search team label Nov 14, 2023
@elasticsearchmachine elasticsearchmachine removed the Team:Enterprise Search Meta label for Enterprise Search team label Nov 14, 2023
@seanstory seanstory added the Team:Search Meta label for search team label Nov 14, 2023
@elasticsearchmachine elasticsearchmachine removed the Team:Search Meta label for search team label Nov 14, 2023
@seanstory seanstory added :EnterpriseSearch/Application Enterprise Search Team:Enterprise Search Meta label for Enterprise Search team labels Nov 14, 2023
@elasticsearchmachine elasticsearchmachine removed the needs:triage Requires assignment of a team area label label Nov 14, 2023
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/ent-search-eng (Team:Enterprise Search)

@elasticsearchmachine
Copy link
Collaborator

Hi @seanstory, I've created a changelog YAML for you.

@seanstory seanstory added v8.11.2 and removed v8.11.1 labels Nov 14, 2023
@seanstory seanstory merged commit 728e364 into main Nov 14, 2023
15 checks passed
@seanstory seanstory deleted the seanstory-patch-1 branch November 14, 2023 15:54
seanstory added a commit to seanstory/elasticsearch that referenced this pull request Nov 14, 2023
* default run_ml_inference should be true

Seems that the default was incorrectly copied when these mapping definitions were moved over from ent-search

* Update docs/changelog/102151.yaml
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
8.10
8.11

seanstory added a commit to seanstory/elasticsearch that referenced this pull request Nov 14, 2023
* default run_ml_inference should be true

Seems that the default was incorrectly copied when these mapping definitions were moved over from ent-search

* Update docs/changelog/102151.yaml
seanstory added a commit that referenced this pull request Nov 16, 2023
* default run_ml_inference should be true

Seems that the default was incorrectly copied when these mapping definitions were moved over from ent-search

* Update docs/changelog/102151.yaml
seanstory added a commit to seanstory/elasticsearch that referenced this pull request Nov 16, 2023
* default run_ml_inference should be true

Seems that the default was incorrectly copied when these mapping definitions were moved over from ent-search

* Update docs/changelog/102151.yaml
andreidan pushed a commit to andreidan/elasticsearch that referenced this pull request Nov 22, 2023
* default run_ml_inference should be true

Seems that the default was incorrectly copied when these mapping definitions were moved over from ent-search

* Update docs/changelog/102151.yaml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Automatically create backport pull requests when merged >bug :EnterpriseSearch/Application Enterprise Search Team:Enterprise Search Meta label for Enterprise Search team v8.10.5 v8.11.2 v8.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants