Add static node settings to set default values for max merged segment sizes #102208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlrx
added
>enhancement
:Distributed/Engine
|
Hi @tlrx, I've created a changelog YAML for you. |
|
Pinging @elastic/es-distributed (Team:Distributed) |
henningandersen
approved these changes
Nov 15, 2023
|
|
||
| public static final double DEFAULT_EXPUNGE_DELETES_ALLOWED = 10d; | ||
| public static final ByteSizeValue DEFAULT_FLOOR_SEGMENT = new ByteSizeValue(2, ByteSizeUnit.MB); | ||
| public static final int DEFAULT_MAX_MERGE_AT_ONCE = 10; | ||
| public static final ByteSizeValue DEFAULT_MAX_MERGED_SEGMENT = new ByteSizeValue(5, ByteSizeUnit.GB); | ||
| public static final Setting<ByteSizeValue> DEFAULT_MAX_MERGED_SEGMENT_SETTING = Setting.byteSizeSetting( | ||
| "merge.policy.default.max_merged_segment", |
There was a problem hiding this comment.
I'd prefer something like:
Suggested change
| "merge.policy.default.max_merged_segment", | |
| "indices.merge.policy.max_merged_segment", |
though adding default could also be fine by me: indices.default.merge.policy.max_merged_segment.
There was a problem hiding this comment.
I pushed 63a93ec to use indices.merge.policy.max_merged_segment
tlrx
deleted the
2023/11/15/node-defaults-for-merge-max-segment-sizes
branch
|
Thanks Henning! |
andreidan
pushed a commit
to andreidan/elasticsearch
that referenced
this pull request
Nov 22, 2023
… sizes (elastic#102208) This change introduces 2 static node-level settings that allow to override the default values for the maximum merged segment sizes in tiered and time-based merge policies. New default values can be defined like this in elasticsearch.yml: indices: merge: policy: max_merged_segment: "5gb" max_time_based_merged_segment: "25gb"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change introduces 2 static node-level settings that allow to override the default values for the maximum merged segment sizes in tiered and time-based merge policies.
New default values can be defined like this in
elasticsearch.yml: