Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix IndexDiskUsageAnalyzerTests with vectors #102320

Merged
merged 4 commits into from
Nov 27, 2023

Conversation

benwtrent
Copy link
Member

@benwtrent benwtrent commented Nov 16, 2023

We need to account for additional disk usage with quantized vectors and the new vector format files

@benwtrent benwtrent added >test Issues or PRs that are addressing/adding tests :Search/Vectors Vector search v8.12.0 labels Nov 16, 2023
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search (Team:Search)

@elasticsearchmachine elasticsearchmachine added the Team:Search Meta label for search team label Nov 16, 2023
@benwtrent benwtrent changed the title Fix diskusage test Fix IndexDiskUsageAnalyzerTests with vectors Nov 16, 2023
@benwtrent
Copy link
Member Author

This still isn't fixed. Right now, when using the quantized codec, we don't account for both the stored float vectors and the quantized ones.

@benwtrent benwtrent merged commit 96b20f2 into elastic:lucene_snapshot Nov 27, 2023
14 checks passed
@benwtrent benwtrent deleted the test/fix-disusage-test branch November 27, 2023 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Search/Vectors Vector search Team:Search Meta label for search team >test Issues or PRs that are addressing/adding tests v8.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants