Fix testSnapshotWithStuckNode #102398
Merged
Fix testSnapshotWithStuckNode #102398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test sometimes relies on repository cleanup to remove all but the `index.latest` and `index-N` blobs, but in fact repo cleanup will leave behind the `index-(N-1)` blob too. This commit relaxes the test to account for this, but then strengthens it to assert that the blobs left in the repo are exactly the ones we expect. Closes elastic#101573
DaveCTurner
added
>test
|
Pinging @elastic/es-distributed (Team:Distributed) |
arteam
approved these changes
Nov 21, 2023
| // Expect two or three files to remain in the repository: | ||
| // (1) index-latest | ||
| // (2) index-(N+1) | ||
| // (3) index-N (maybe: a fully successful deletion removes this, but cleanup does not, see #100718) |
There was a problem hiding this comment.
Is it this one https://github.com/elastic/elasticsearch/pull/101718/files ?
Does not seem related
DaveCTurner
deleted the
2023/11/21/testSnapshotWithStuckNode-lenience
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test sometimes relies on repository cleanup to remove all but the
index.latestandindex-Nblobs, but in fact repo cleanup will leavebehind the
index-(N-1)blob too. This commit relaxes the test toaccount for this, but then strengthens it to assert that the blobs left
in the repo are exactly the ones we expect.
Closes #101573