Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ESQL: emit warnings from single-value functions processing multi-values #102417

Merged
merged 21 commits into from
Dec 5, 2023
Merged

ESQL: emit warnings from single-value functions processing multi-values #102417

merged 21 commits into from
Dec 5, 2023
+3,626 −785

Commits on Oct 4, 2023

  1. Add Warning headers when SV functions encounter MV 

    This adds Warning headers when scalar singlevalue functions enounter
multivalues (and emits a `null`).
    @bpintea
    bpintea committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    0f576e1 View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2023

  1. Generate warnings from within SingleValueQuery 

    This adds warning generation to SingleValueQuery.

Two issues with this approch, however:
- the source is serialized with the text, the EsqlConfiguration isn't
  made available.
- the translation of queries for Lucene differs from the exec engine, in
  respect to not(): `must_not` query "contains" the `not` and includes
  it in its source, while in the exec engine its execution happens in
  two separate steps (so the warning is added to the predicate the not()
  negates).
    @bpintea
    bpintea committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    6bc8da3 View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2023

  1. Allow different warnings for Rest and CSV tests 

    Allow slightly different warnings for Rest and CSV tests.
    @bpintea
    bpintea committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    1f896fa View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2023

  1. Merge branch 'main' into esql/warn_sv_func_on_mv2

    @bpintea
    bpintea committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    ed90baf View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2023

  1. Merge branch 'main' into esql/warn_sv_func_on_mv2

    @bpintea
    bpintea committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    7993278 View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2023

  1. Merge branch 'main' into esql/warn_sv_func_on_mv2

    @bpintea
    bpintea committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    715114e View commit details
    Browse the repository at this point in the history

  2. Update unit tests to SV-funcs warnings

    @bpintea
    bpintea committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    e774a85 View commit details
    Browse the repository at this point in the history

  3. Fix generation of warnings in the evaluators 

    Currently, this was done on a `"values_count()" != 1`, which is wrong,
since it has to differentiate from a 0 count.
    @bpintea
    bpintea committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    9705e9b View commit details
    Browse the repository at this point in the history

  4. Update docs/changelog/102417.yaml

    @bpintea
    bpintea committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    d921a23 View commit details
    Browse the repository at this point in the history

  5. Update docs/changelog/102417.yaml

    @bpintea
    bpintea committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    f73f890 View commit details
    Browse the repository at this point in the history

  6. Spotless

    @bpintea
    bpintea committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    66042ed View commit details
    Browse the repository at this point in the history

  7. Spotless

    @bpintea
    bpintea committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    b5d8308 View commit details
    Browse the repository at this point in the history

  8. Skip some bwc tests 

    Skip bwc tests on pre 8.12 versions.
Also, fix doc test.
    @bpintea
    bpintea committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    f2451a6 View commit details
    Browse the repository at this point in the history

  9. Merge branch 'main' into esql/warn_sv_func_on_mv2

    @bpintea
    bpintea committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    e353b47 View commit details
    Browse the repository at this point in the history

Commits on Nov 23, 2023

  1. Address review comments

    @bpintea
    bpintea committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    4b65f5d View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into esql/warn_sv_func_on_mv2

    @bpintea
    bpintea committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    e14b485 View commit details
    Browse the repository at this point in the history

Commits on Dec 4, 2023

  1. Merge branch 'main' into esql/warn_sv_func_on_mv2

    @bpintea
    bpintea committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    3ea8c03 View commit details
    Browse the repository at this point in the history

  2. Update geo comparasion

    @bpintea
    bpintea committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    5b1a6b7 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into esql/warn_sv_func_on_mv2

    @bpintea
    bpintea committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    2a6368f View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into esql/warn_sv_func_on_mv2

    @bpintea
    bpintea committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    bf388c5 View commit details
    Browse the repository at this point in the history

Commits on Dec 5, 2023

  1. Merge branch 'main' into esql/warn_sv_func_on_mv2

    @bpintea
    bpintea committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    7992f8a View commit details
    Browse the repository at this point in the history