Check the real memory circuit breaker when building global ordinals #102462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elasticsearchmachine
added
the
Team:Analytics
|
Pinging @elastic/es-analytics-geo (Team:Analytics) |
|
Hi @iverase, I've created a changelog YAML for you. |
iverase
commented
Nov 22, 2023
server/src/main/java/org/elasticsearch/index/fielddata/ordinals/GlobalOrdinalsBuilder.java
Show resolved
Hide resolved
jpountz
approved these changes
Nov 22, 2023
There was a problem hiding this comment.
Thanks for looking into this, this is the kind of approach I had in mind. From a quick look, checking the circuit breaker is not so cheap, but doing it infrequently, every 8192 terms, should help amortize this cost. I wonder if we should do it even more infrequently, e.g. every 64k terms, since only adding 8k terms should not allocate lots of heap
server/src/main/java/org/elasticsearch/index/fielddata/ordinals/GlobalOrdinalsBuilder.java
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/index/fielddata/ordinals/GlobalOrdinalsBuilder.java
Outdated
Show resolved
Hide resolved
|
I upddated it so we do the check every 65536 calls. |
11 tasks
andreidan
pushed a commit
to andreidan/elasticsearch
that referenced
this pull request
Nov 22, 2023
…lastic#102462) This commit improves the way we build global ordinals by checking the parent circuit breaker every 65536 calls to TermsEnum#next.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently global ordinals are built without any protection against out of memory errors, even though they can use quite a bit of heap. This PR improves the way we build global ordinals by checking the parent circuit breaker every
819265536 calls to TermsEnum#next.