Allow executing multiple periodic flushes while they are being made durable #102571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…urable Relates ES-7200
fcofdez
added
>enhancement
:Distributed/Store
|
Pinging @elastic/es-distributed (Team:Distributed) |
|
Hi @fcofdez, I've created a changelog YAML for you. |
henningandersen
approved these changes
Nov 24, 2023
| * Executes the given flush request against the engine. | ||
| * | ||
| * @param request the flush request | ||
| * @param listener to notify after fully durability has been achieved. |
There was a problem hiding this comment.
nit:
Suggested change
| * @param listener to notify after fully durability has been achieved. | |
| * @param listener to notify after full durability has been achieved. |
| } | ||
| }); | ||
| afterWriteOperation(); | ||
| flushOrRollRunning.compareAndSet(true, false); |
There was a problem hiding this comment.
I think we have to still reset before calling the method back, since otherwise it will always bail out early on the re-invocation?
timgrein
pushed a commit
to timgrein/elasticsearch
that referenced
this pull request
Nov 30, 2023
…urable (elastic#102571) Closes ES-7200
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates ES-7200