Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce transport version for the next lucene upgrade #102587

Conversation

javanna
Copy link
Member

@javanna javanna commented Nov 24, 2023

No description provided.

@javanna javanna added >non-issue :Search/Search Search-related issues that do not fall into other categories v8.12.0 labels Nov 24, 2023
@elasticsearchmachine elasticsearchmachine added the Team:Search Meta label for search team label Nov 24, 2023
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search (Team:Search)

Copy link
Contributor

@ChrisHegarty ChrisHegarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++ LGTM

@ChrisHegarty
Copy link
Contributor

ChrisHegarty commented Nov 24, 2023

I agree with a single TV to accumulate all transport changes associated with the Lucene upgrade, since the upgrade will be merged (into main) from the lucene_snapshot branch in a single commit. There is no need to retain transient TV's in the lucene_snapshot branch.

@javanna javanna merged commit 954dee6 into elastic:lucene_snapshot Nov 24, 2023
14 checks passed
@javanna javanna deleted the refactoring/lucene_upgrade_transport_version branch November 24, 2023 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>non-issue :Search/Search Search-related issues that do not fall into other categories Team:Search Meta label for search team v8.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants