Assert aborted snapshots have no pending shard work #102621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a snapshot is aborted, all shard snapshots must either be complete (`SUCCESS`, `FAILED` or `MISSING`) or else they must be in state `ABORTED` while the data node finishes its work. It seems we do not check this invariant anywhere today, so this commit adds an assertion of this invariant.
DaveCTurner
added
>test
|
Pinging @elastic/es-distributed (Team:Distributed) |
ywangd
approved these changes
Nov 27, 2023
There was a problem hiding this comment.
LGTM
Just need to fix the test failure which is due to the randomized State for SnapshotsInProgress#Entry not respecting the new assertion.
DaveCTurner
added
the
auto-merge
server/src/main/java/org/elasticsearch/cluster/SnapshotsInProgress.java
Outdated
Show resolved
Hide resolved
server/src/test/java/org/elasticsearch/snapshots/SnapshotsInProgressSerializationTests.java
Outdated
Show resolved
Hide resolved
idegtiarenko
approved these changes
Nov 27, 2023
DaveCTurner
removed
the
auto-merge
DaveCTurner
added
the
auto-merge
DaveCTurner
deleted the
2023/11/26/assert-no-pending-work-in-aborted-snapshot
branch
timgrein
pushed a commit
to timgrein/elasticsearch
that referenced
this pull request
Nov 30, 2023
When a snapshot is aborted, all shard snapshots must either be complete (`SUCCESS`, `FAILED` or `MISSING`) or else they must be in state `ABORTED` while the data node finishes its work. It seems we do not check this invariant anywhere today, so this commit adds an assertion of this invariant.
DaveCTurner
restored the
2023/11/26/assert-no-pending-work-in-aborted-snapshot
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a snapshot is aborted, all shard snapshots must either be complete
(
SUCCESS,FAILEDorMISSING) or else they must be in stateABORTEDwhile the data node finishes its work. It seems we do notcheck this invariant anywhere today, so this commit adds an assertion of
this invariant.