Enable concurrency for multi terms agg #102710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit enables concurrency for multi terms agg if all sub-terms agg target low cardinality fields.
elasticsearchmachine
added
the
Team:Analytics
|
Pinging @elastic/es-analytics-geo (Team:Analytics) |
|
Hi @javanna, I've created a changelog YAML for you. |
javanna
commented
Nov 28, 2023
| @@ -168,64 +167,52 @@ private List<BucketOrder> randomOrder() { | |||
|
|
|||
| public void testSupportsParallelCollection() { | |||
| { | |||
| AggregatorFactories.Builder builder = new AggregatorFactories.Builder(); | |||
There was a problem hiding this comment.
I realized that I don't need to test AggregatorFactories.Builder here, hence I simplified the test while I was at it.
javanna
commented
Nov 28, 2023
| return false; | ||
| } | ||
| }); | ||
| assertFalse(builder.supportsParallelCollection(null)); |
There was a problem hiding this comment.
Here I added a missing test that verifies that we still look at sub-aggs for composite agg, when all the sources support concurrency.
timgrein
pushed a commit
to timgrein/elasticsearch
that referenced
this pull request
Nov 30, 2023
This commit enables concurrency for multi terms agg if all sub-terms agg target low cardinality fields.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit enables concurrency for multi terms agg if all sub-terms agg target low cardinality fields.