Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix leaking blocks in TopN #102715

Merged
merged 2 commits into from Nov 28, 2023
Merged

Fix leaking blocks in TopN #102715

merged 2 commits into from Nov 28, 2023

Conversation

dnhatn
Copy link
Member

@dnhatn dnhatn commented Nov 28, 2023

Closes #102646

@dnhatn dnhatn added >bug auto-backport-and-merge Automatically create backport pull requests and merge when ready :Analytics/ES|QL AKA ESQL v8.12.0 v8.11.2 labels Nov 28, 2023
@elasticsearchmachine elasticsearchmachine added the Team:QL (Deprecated) Meta label for query languages team label Nov 28, 2023
@elasticsearchmachine
Copy link
Collaborator

Hi @dnhatn, I've created a changelog YAML for you.

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-ql (Team:QL)

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/elasticsearch-esql (:Query Languages/ES|QL)

@dnhatn dnhatn mentioned this pull request Nov 28, 2023
Closed
alex-spies
alex-spies approved these changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@alex-spies alex-spies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dnhatn
Copy link
Member Author

dnhatn commented Nov 28, 2023

@nik9000 @alex-spies Thanks!

@dnhatn dnhatn merged commit fcdeb95 into elastic:main Nov 28, 2023
14 checks passed
@dnhatn dnhatn deleted the fix-memory-leak branch November 28, 2023 16:31
@dnhatn dnhatn mentioned this pull request Nov 28, 2023
Merged
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
✅ 8.11

dnhatn added a commit to dnhatn/elasticsearch that referenced this pull request Nov 28, 2023
@dnhatn
Fix leaking blocks in TopN (elastic#102715)
41a3263 
Closes elastic#102646
elasticsearchmachine pushed a commit that referenced this pull request Nov 28, 2023
@dnhatn
Fix leaking blocks in TopN (#102715) (#102718)
90b1f42 
Closes #102646
timgrein pushed a commit to timgrein/elasticsearch that referenced this pull request Nov 30, 2023
@dnhatn @timgrein
Fix leaking blocks in TopN (elastic#102715)
2513867 
Closes elastic#102646
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nik9000 nik9000 nik9000 approved these changes

@alex-spies alex-spies alex-spies approved these changes

Assignees
No one assigned
Labels
:Analytics/ES|QL AKA ESQL auto-backport-and-merge Automatically create backport pull requests and merge when ready >bug Team:QL (Deprecated) Meta label for query languages team v8.11.2 v8.12.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CI] EsqlActionBreakerIT testLoadId and 26 others failing
4 participants
@dnhatn @elasticsearchmachine @nik9000 @alex-spies