[Profiling] Report in status API if docs exist #102735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this commit we add a new field `has_data` to the profiling status API. This field is true iff there is at least one profiling event. As profiling events are the aggregate root in the profiling domain model, it is sufficient to check for presence of documents in that data stream.
danielmitterdorfer
added
>enhancement
:UniversalProfiling/Application
|
Pinging @elastic/profiling (Team:Universal Profiling) |
|
Hi @danielmitterdorfer, I've created a changelog YAML for you. |
rockdaboot
reviewed
Nov 29, 2023
| for (Index index : dataStream.getIndices()) { | ||
| IndexMetadata meta = state.metadata().index(index); | ||
| if (meta == null) { | ||
| return false; |
There was a problem hiding this comment.
What if there are many indices but only one doesn't have metadata? Should we not continue here?
There was a problem hiding this comment.
Fair point. I've pushed e11f4a8.
timgrein
pushed a commit
to timgrein/elasticsearch
that referenced
this pull request
Nov 30, 2023
With this commit we add a new field `has_data` to the profiling status API. This field is true iff there is at least one profiling event. As profiling events are the aggregate root in the profiling domain model, it is sufficient to check for presence of documents in that data stream.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this commit we add a new field
has_datato the profiling status API. This field is true iff there is at least one profiling event. As profiling events are the aggregate root in the profiling domain model, it is sufficient to check for presence of documents in that data stream.