Upgrade to Lucene 9.9.0 #102782
Merged
Upgrade to Lucene 9.9.0 #102782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds new max_inner_product vector similarity function. This differs from dot_product in the following ways: Doesn't require vectors to be normalized Scales the similarity between vectors differently to prevent negative scores
This adds a version for the Lucene upgrade and adjusts some tests.
…#99962) Fix compiling error after adding a new method to RandomAccessInput interface.
|
Pinging @elastic/es-search (Team:Search) |
|
Hi @ChrisHegarty, I've created a changelog YAML for you. |
ChrisHegarty
commented
Nov 30, 2023
server/src/main/java/org/elasticsearch/index/IndexVersions.java
Outdated
Show resolved
Hide resolved
|
@elasticsearchmachine run elasticsearch-ci/part-1 |
benwtrent
added
the
cloud-deploy
Quantized search result scores can be slightly different depending on if they are merged into a single segment, etc.
benwtrent
force-pushed
the
lucene_snapshot_9_9
branch
from
68fd12c
to
eaa5889
Compare
|
This all looks good to me, besides one small thing: I think we are missing a changelog for the " Automatically quantize vectors for kNN search" change, is that possible @benwtrent ? |
|
@javanna you are correct, let me commit it really quick |
|
@elasticsearchmachine run elasticsearch-ci/part-1 |
benwtrent
approved these changes
Dec 4, 2023
Comment on lines
+109
to
+112
| Matcher matcher; | ||
| if ("UPGRADE_TO_LUCENE_9_9".equals(field.getName())) { | ||
| // OK | ||
| } else if ((matcher = historicalVersion.matcher(field.getName())).matches()) { |
There was a problem hiding this comment.
This is the only thing I don't really understand. But the PR is ++ from me!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade to Lucene 9.9.0
TODO:
Note: This PR will merge it's commits into main (rather than squashing), in order to preserve history and already-reviewed changes.