Fix layout for MV_EXPAND #102916
Merged
Fix layout for MV_EXPAND #102916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elasticsearchmachine
added
Team:QL (Deprecated)
|
Pinging @elastic/es-ql (Team:QL) |
|
Pinging @elastic/elasticsearch-esql (:Query Languages/ES|QL) |
|
Hi @luigidellaquila, I've created a changelog YAML for you. |
|
@elasticmachine run elasticsearch-ci/docs |
|
@elasticmachine update branch |
alex-spies
approved these changes
Dec 4, 2023
Comment on lines
584
to
587
| List<Attribute> childOutput = mvExpandExec.child().output(); | ||
| int blockSize = 5000;// TODO estimate row size and use context.pageSize() | ||
|
|
||
| Layout.Builder layout = new Layout.Builder(); | ||
| List<Layout.ChannelSet> inverse = source.layout.inverse(); | ||
| var expandedName = mvExpandExec.expanded().name(); | ||
| for (int index = 0; index < inverse.size(); index++) { | ||
| if (childOutput.get(index).name().equals(expandedName)) { | ||
| layout.append(mvExpandExec.expanded()); | ||
| } else { | ||
| layout.append(inverse.get(index)); | ||
| } | ||
| } | ||
|
|
||
| // Layout outputLayout = outputLayout(source, mvExpandExec); | ||
| Layout.Builder layout = source.layout.builder(); | ||
| layout.replace(mvExpandExec.target().id(), mvExpandExec.expanded().id()); |
There was a problem hiding this comment.
++ this is much easier to understand and verify
…into esql/mv_expand_layout
|
@elasticmachine run elasticsearch-ci/docs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #102912
Fixing MV_EXPAND layout by manually replacing the input attribute with the output one (that is what practically the operator does).