Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Transform] Ensure transform _schedule_now API only triggers the expected transform task #102958

Merged
merged 2 commits into from Dec 5, 2023

Conversation

przemekwitek
Copy link
Contributor

TransportScheduleNowTransformAction is a TransportTasksAction which means that it fans out to individual tasks running on the nodes.
In order to find the appropriate tasks the match method must be implemented properly. For the _schedule_now action request the match implementation was missing which caused the action to call scheduler for the given transform multiple times (equal to the number of transforms running on the same node as the requested transform) instead of just one.
This PR implements the match method so that the problem is fixed.

Closes #102956

@przemekwitek przemekwitek added >bug :ml/Transform Transform auto-backport-and-merge Automatically create backport pull requests and merge when ready v8.11.0 v8.12.0 labels Dec 5, 2023
@elasticsearchmachine elasticsearchmachine added the Team:ML Meta label for the ML team label Dec 5, 2023
@elasticsearchmachine
Copy link
Collaborator

Hi @przemekwitek, I've created a changelog YAML for you.

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/ml-core (Team:ML)

Copy link
Contributor

@droberts195 droberts195 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@przemekwitek przemekwitek merged commit 56170b4 into elastic:main Dec 5, 2023
15 checks passed
@przemekwitek przemekwitek deleted the schedule_now_match branch December 5, 2023 09:37
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
8.11

przemekwitek added a commit to przemekwitek/elasticsearch that referenced this pull request Dec 5, 2023
elasticsearchmachine pushed a commit that referenced this pull request Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport-and-merge Automatically create backport pull requests and merge when ready >bug :ml/Transform Transform Team:ML Meta label for the ML team v8.11.3 v8.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Transform] Potential bug in transform _schedule_now API.
3 participants