New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Connectors API] Enable as technical preview #102994
Merged
jedrazb
merged 8 commits into
elastic:main
from
jedrazb:connectors-api-feature-tech-preview
Dec 5, 2023
Merged
[Connectors API] Enable as technical preview #102994
jedrazb
merged 8 commits into
elastic:main
from
jedrazb:connectors-api-feature-tech-preview
Dec 5, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jedrazb
added
>feature
:EnterpriseSearch/Application
Enterprise Search
Team:Enterprise Search
Meta label for Enterprise Search team
v8.12.0
and removed
v8.13.0
labels
Dec 5, 2023
Pinging @elastic/ent-search-eng (Team:Enterprise Search) |
timgrein
reviewed
Dec 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think connector.check_in.json
needs to be adapted as well?
timgrein
approved these changes
Dec 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's go! Nice work 👏
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
:EnterpriseSearch/Application
Enterprise Search
>feature
Team:Enterprise Search
Meta label for Enterprise Search team
v8.12.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The API is intended to be released in
8.12
as technical preview. Therefore, setting the feature as enabled by default.Instead of removing the feature flag from the code, we enable it by default. This approach allows for the complete deactivation of the feature during the QA phase, should any critical bugs be discovered, with a simple change.
Similar PR for reference: #97466