Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Connectors API] Enable as technical preview #102994

Merged
merged 8 commits into from Dec 5, 2023

Conversation

jedrazb
Copy link
Member

@jedrazb jedrazb commented Dec 5, 2023

The API is intended to be released in 8.12 as technical preview. Therefore, setting the feature as enabled by default.

Instead of removing the feature flag from the code, we enable it by default. This approach allows for the complete deactivation of the feature during the QA phase, should any critical bugs be discovered, with a simple change.

Similar PR for reference: #97466

@jedrazb jedrazb added >feature :EnterpriseSearch/Application Enterprise Search Team:Enterprise Search Meta label for Enterprise Search team v8.12.0 and removed v8.13.0 labels Dec 5, 2023
@jedrazb jedrazb marked this pull request as ready for review December 5, 2023 17:07
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/ent-search-eng (Team:Enterprise Search)

Copy link
Contributor

@timgrein timgrein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think connector.check_in.json needs to be adapted as well?

Copy link
Contributor

@timgrein timgrein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go! Nice work 👏

@jedrazb jedrazb merged commit e8907da into elastic:main Dec 5, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:EnterpriseSearch/Application Enterprise Search >feature Team:Enterprise Search Meta label for Enterprise Search team v8.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants