Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix format string in OldLuceneVersions #103185

Merged
merged 2 commits into from Dec 11, 2023
Merged

Fix format string in OldLuceneVersions #103185

merged 2 commits into from Dec 11, 2023

Conversation

DaveCTurner
Copy link
Contributor

The message introduced in #92986 used {} instead of %s for the
placeholders, which doesn't work for Strings.format. This commit fixes
the problem.

@DaveCTurner
Fix format string in OldLuceneVersions
b22e1d0 
The message introduced in elastic#92986 used `{}` instead of `%s` for the
placeholders, which doesn't work for `Strings.format`. This commit fixes
the problem.
@DaveCTurner DaveCTurner added >bug :Search/Search Search-related issues that do not fall into other categories auto-backport-and-merge Automatically create backport pull requests and merge when ready v8.11.3 v8.12.1 v8.13.0 labels Dec 8, 2023
@elasticsearchmachine elasticsearchmachine added the Team:Search Meta label for search team label Dec 8, 2023
@elasticsearchmachine
Copy link
Collaborator

Hi @DaveCTurner, I've created a changelog YAML for you.

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search (Team:Search)

@DaveCTurner DaveCTurner mentioned this pull request Dec 8, 2023
Open
ldematte
ldematte approved these changes Dec 11, 2023
View reviewed changes
Copy link
Contributor

@ldematte ldematte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DaveCTurner DaveCTurner merged commit cd2e294 into elastic:main Dec 11, 2023
15 checks passed
@DaveCTurner DaveCTurner deleted the 2023/12/08/OldLuceneVersions-format-string branch December 11, 2023 08:37
@DaveCTurner DaveCTurner mentioned this pull request Dec 11, 2023
Merged
DaveCTurner added a commit to DaveCTurner/elasticsearch that referenced this pull request Dec 11, 2023
@DaveCTurner
Fix format string in OldLuceneVersions (elastic#103185)
d7b5ca6 
The message introduced in elastic#92986 used `{}` instead of `%s` for the
placeholders, which doesn't work for `Strings.format`. This commit fixes
the problem.
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
✅ 8.12

elasticsearchmachine pushed a commit that referenced this pull request Dec 11, 2023
@DaveCTurner
Fix format string in OldLuceneVersions (#103185) (#103258)
77689cf 
The message introduced in #92986 used `{}` instead of `%s` for the
placeholders, which doesn't work for `Strings.format`. This commit fixes
the problem.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ldematte ldematte ldematte approved these changes

@javanna javanna Awaiting requested review from javanna

Assignees
No one assigned
Labels
auto-backport-and-merge Automatically create backport pull requests and merge when ready >bug :Search/Search Search-related issues that do not fall into other categories Team:Search Meta label for search team v8.12.1 v8.13.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@DaveCTurner @elasticsearchmachine @ldematte