Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Synonyms] Mark Synonyms as GA #103223

Merged
merged 7 commits into from Dec 14, 2023
Merged

[Synonyms] Mark Synonyms as GA #103223

merged 7 commits into from Dec 14, 2023

Conversation

kderusso
Copy link
Member

@kderusso kderusso commented Dec 8, 2023

Removes the beta flag from Synonyms docs and json definitions, marking the synonyms API as GA.

@kderusso kderusso added >docs General docs changes :Search/Search Search-related issues that do not fall into other categories Team:Search Meta label for search team :EnterpriseSearch/Application Enterprise Search Team:Enterprise Search Meta label for Enterprise Search team labels Dec 8, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 8, 2023

Documentation preview:

@kderusso kderusso changed the title [Synonyms] Remove beta from docs and json definitions [Synonyms] Mark Synonyms as GA Dec 8, 2023
@kderusso kderusso force-pushed the kderusso/synonyms-remove-beta branch from 592879a to 57a3be2 Compare December 8, 2023 20:49
@kderusso kderusso requested review from carlosdelest and a team December 11, 2023 20:24
@kderusso kderusso marked this pull request as ready for review December 11, 2023 20:24
@elasticsearchmachine elasticsearchmachine added the Team:Docs Meta label for docs team label Dec 11, 2023
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search (Team:Search)

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/ent-search-eng (Team:Enterprise Search)

carlosdelest
carlosdelest approved these changes Dec 12, 2023
View reviewed changes
Copy link
Member

@carlosdelest carlosdelest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

carlosdelest
carlosdelest reviewed Dec 12, 2023
View reviewed changes
Copy link
Member

@carlosdelest carlosdelest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should making this feature GA have a changelog / release note added to it? @abdonpijpelink, is there anything else we need to provide as part of this?

@abdonpijpelink
Copy link
Contributor

abdonpijpelink commented Dec 12, 2023 •
edited

You can consider making this a release highlight. Here's a similar recent example: https://github.com/elastic/elasticsearch/pull/95398/files

Note the release highlight label and the yaml file with the highlight section. That will translate into a highlight like this: https://www.elastic.co/guide/en/elasticsearch/reference/8.8/release-highlights.html#ga_release_of_jwt_realm

Mikep86
Mikep86 approved these changes Dec 12, 2023
View reviewed changes
Copy link
Contributor

@Mikep86 Mikep86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticsearchmachine
Copy link
Collaborator

Hi @kderusso, I've created a changelog YAML for you. Note that since this PR is labelled release highlight, you need to update the changelog YAML to fill out the extended information sections.

@kderusso
Copy link
Member Author

@elasticmachine update branch

@kderusso
Copy link
Member Author

@elasticmachine update branch

@kderusso kderusso merged commit a2dc45b into elastic:main Dec 14, 2023
15 checks passed
@codebrain codebrain mentioned this pull request Feb 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlosdelest carlosdelest carlosdelest approved these changes

@Mikep86 Mikep86 Mikep86 approved these changes

Assignees
No one assigned
Labels
>docs General docs changes :EnterpriseSearch/Application Enterprise Search release highlight :Search/Search Search-related issues that do not fall into other categories Team:Docs Meta label for docs team Team:Enterprise Search Meta label for Enterprise Search team Team:Search Meta label for search team v8.13.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@kderusso @elasticsearchmachine @abdonpijpelink @carlosdelest @Mikep86 @elasticmachine